LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	rth@twiddle.net
Subject: Re: [PATCH] Stop making "inline" imply forced inlining.
Date: Fri, 19 Jan 2007 18:25:42 +0100	[thread overview]
Message-ID: <20070119172542.GO9093@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0701191156000.24621@CPE00045a9c397f-CM001225dbafb6>

On Fri, Jan 19, 2007 at 11:56:30AM -0500, Robert P. J. Day wrote:
> 
>   Remove the macros that define simple "inlining" to mean forced
> inlining, since you can (and *should*) get that effect with the
> CONFIG_FORCED_INLINING kernel config variable instead.

NAK.

I don't see any place in the kernel where we need a non-forced inline.

We have tons of inline's in C files that should simply be removed - 
let's do this instead.

> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> 
> ---
> 
>   this change was compile tested on x86 with "make allyesconfig",
> followed by turning off forced inlining.
> 
>   now the alpha folks can simplify their compiler.h file. :-)
> 
> 
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> index 6e1c44a..5a90bd9 100644
> --- a/include/linux/compiler-gcc.h
> +++ b/include/linux/compiler-gcc.h
> @@ -23,9 +23,6 @@
>      (typeof(ptr)) (__ptr + (off)); })
> 
> 
> -#define inline		inline		__attribute__((always_inline))
> -#define __inline__	__inline__	__attribute__((always_inline))
> -#define __inline	__inline	__attribute__((always_inline))
>  #define __deprecated			__attribute__((deprecated))
>  #define  noinline			__attribute__((noinline))
>  #define __attribute_pure__		__attribute__((pure))

Oh, and your patch would have been broken for gcc < 4.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2007-01-19 17:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-19 16:56 Robert P. J. Day
2007-01-19 17:25 ` Adrian Bunk [this message]
2007-01-19 17:39   ` Robert P. J. Day
2007-01-19 18:40     ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070119172542.GO9093@stusta.de \
    --to=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpjday@mindspring.com \
    --cc=rth@twiddle.net \
    --subject='Re: [PATCH] Stop making "inline" imply forced inlining.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).