LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler
@ 2007-01-19 21:51 Hoang-Nam Nguyen
  2007-01-20 15:20 ` Hoang-Nam Nguyen
  0 siblings, 1 reply; 4+ messages in thread
From: Hoang-Nam Nguyen @ 2007-01-19 21:51 UTC (permalink / raw)
  To: Roland Dreier, linux-kernel, linuxppc-dev, openfabrics-ewg,
	openib-general
  Cc: raisch

Hello Roland!
This is a patch for ehca_irq.c that fixes an unproper use of spin_unlock
in irq handler.
Thanks
Nam


Signed-off-by Hoang-Nam Nguyen <hnguyen@de.ibm.com>
---


 ehca_irq.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)


diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c b/drivers/infiniband/hw/ehca/ehca_irq.c
index e7209af..93788d8 100644
--- a/drivers/infiniband/hw/ehca/ehca_irq.c
+++ b/drivers/infiniband/hw/ehca/ehca_irq.c
@@ -440,7 +440,7 @@ void ehca_tasklet_eq(unsigned long data)
 					cq = idr_find(&ehca_cq_idr, token);
 
 					if (cq == NULL) {
-						spin_unlock(&ehca_cq_idr_lock);
+						spin_unlock_irqrestore(&ehca_cq_idr_lock, flags);
 						break;
 					}
 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler
  2007-01-19 21:51 [PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler Hoang-Nam Nguyen
@ 2007-01-20 15:20 ` Hoang-Nam Nguyen
  2007-01-22 21:14   ` Roland Dreier
  0 siblings, 1 reply; 4+ messages in thread
From: Hoang-Nam Nguyen @ 2007-01-20 15:20 UTC (permalink / raw)
  To: Roland Dreier, linux-kernel, linuxppc-dev, openfabrics-ewg,
	openib-general
  Cc: raisch

hmm, code line too long. please ignore the previous patch. here is the one
with correct length of code line.
Thanks
Nam


This is a patch for ehca_irq.c that fixes an unproper use of spin_unlock
in irq handler.


Signed-off-by Hoang-Nam Nguyen <hnguyen@de.ibm.com>
---


 ehca_irq.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletion(-)


diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c b/drivers/infiniband/hw/ehca/ehca_irq.c
index e7209af..fd1a5fb 100644
--- a/drivers/infiniband/hw/ehca/ehca_irq.c
+++ b/drivers/infiniband/hw/ehca/ehca_irq.c
@@ -440,7 +440,9 @@ void ehca_tasklet_eq(unsigned long data)
 					cq = idr_find(&ehca_cq_idr, token);
 
 					if (cq == NULL) {
-						spin_unlock(&ehca_cq_idr_lock);
+						spin_unlock_irqrestore(
+							&ehca_cq_idr_lock,
+							flags);
 						break;
 					}
 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler
  2007-01-20 15:20 ` Hoang-Nam Nguyen
@ 2007-01-22 21:14   ` Roland Dreier
  2007-01-22 21:33     ` Hoang-Nam Nguyen
  0 siblings, 1 reply; 4+ messages in thread
From: Roland Dreier @ 2007-01-22 21:14 UTC (permalink / raw)
  To: Hoang-Nam Nguyen
  Cc: linux-kernel, linuxppc-dev, openfabrics-ewg, openib-general, raisch

Thanks, queued for 2.6.20 (although I left the line a little longer).

I think the right thing to do is restructure this function so you
don't have lines starting 6 tab stops to the right.

 - R.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler
  2007-01-22 21:14   ` Roland Dreier
@ 2007-01-22 21:33     ` Hoang-Nam Nguyen
  0 siblings, 0 replies; 4+ messages in thread
From: Hoang-Nam Nguyen @ 2007-01-22 21:33 UTC (permalink / raw)
  To: Roland Dreier
  Cc: Christoph Raisch, Hoang-Nam Nguyen, linux-kernel, linuxppc-dev,
	linuxppc-dev-bounces+hnguyen=de.ibm.com, openfabrics-ewg,
	openib-general

> I think the right thing to do is restructure this function so you
> don't have lines starting 6 tab stops to the right.
Yes. Have reworked this irq handler and still struggling with testing.
When we feel comfortable with the test result, we'll post it here (soon)
and hopefully it is easier to read.
Regards
Nam


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-01-22 21:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-19 21:51 [PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler Hoang-Nam Nguyen
2007-01-20 15:20 ` Hoang-Nam Nguyen
2007-01-22 21:14   ` Roland Dreier
2007-01-22 21:33     ` Hoang-Nam Nguyen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).