Re: intel-agp PM experiences (was: 2.6.20-rc5: usb mouse breaks suspend to ram)

[Wang Zhenyu <zhenyu.z.wang@intel.com>]

On 2007.01.18 23:16:51 +0000, Pavel Machek wrote:
> Hi!
> 
> > > > Especially the PCI video_state trick finally got me a working resume on
> > > > 2.6.19-ck2 r128 Rage Mobility M4 AGP *WITH*(!) fully enabled and working
> > > > (and keeping working!) DRI (3D).
> > > 
> > > Can we get whitelist entry for suspend.sf.net? s2ram from there can do
> > > all the tricks you described, one letter per trick :-). We even got
> > > PCI saving lately.
> > 
> > Whitelist? Let me blacklist it all the way to Timbuktu instead!
> 
> > I've been doing more testing, and X never managed to come back to working
> > state without some of my couple intel-agp changes:
> > - a proper suspend method, doing a proper pci_save_state()
> >   or improved equivalent
> > - a missing resume check for my i815 chipset
> > - global cache flush in _configure
> > - restoring AGP bridge PCI config space
> 
> Can you post a patch?

I've post a patch which trys to resolve pci config restore issue, see
http://lkml.org/lkml/2007/1/16/297. It resolves s3 issue with my 965G machine,
that my X can come back to live after s3, but I wasn't aware of the issues Andreas
has noted. It'll be good if more people could try this out. 

> Whitelist entry would still be welcome.
> 
> > All in all intel-agp code semi-shattered my universe.
> > I didn't expect to find all these issues in rather important core code
> ...
> > Given the myriads of resume issues we experience in general,
> > it may be wise to do something as simple as a code review of *all*
> 
> Any volunteers?
> 							Pavel