LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [2.6 patch] echo3g_dsp.c shouldn't include #include <linux/irq.h>
@ 2007-01-23 15:17 Adrian Bunk
  2007-01-23 18:24 ` [Alsa-devel] " Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2007-01-23 15:17 UTC (permalink / raw)
  To: Giuliano Pochini, perex; +Cc: alsa-devel, linux-kernel

Despite being under linux/, linux/irq.h shouldn't be #include'd by arch 
independent code.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.20-rc4-mm1/sound/pci/echoaudio/echo3g_dsp.c.old	2007-01-23 15:16:37.000000000 +0100
+++ linux-2.6.20-rc4-mm1/sound/pci/echoaudio/echo3g_dsp.c	2007-01-23 14:22:49.000000000 +0100
@@ -39,7 +39,7 @@
 static int write_control_reg(struct echoaudio *chip, u32 ctl, u32 frq,
 			     char force);
 
-#include <linux/irq.h>
+#include <linux/interrupt.h>
 
 static int init_hw(struct echoaudio *chip, u16 device_id, u16 subdevice_id)
 {



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Alsa-devel] [2.6 patch] echo3g_dsp.c shouldn't include #include <linux/irq.h>
  2007-01-23 15:17 [2.6 patch] echo3g_dsp.c shouldn't include #include <linux/irq.h> Adrian Bunk
@ 2007-01-23 18:24 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2007-01-23 18:24 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Giuliano Pochini, perex, alsa-devel, linux-kernel

At Tue, 23 Jan 2007 16:17:56 +0100,
Adrian Bunk wrote:
> 
> Despite being under linux/, linux/irq.h shouldn't be #include'd by arch 
> independent code.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Thanks, I applied to ALSA tree now.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-01-23 18:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-23 15:17 [2.6 patch] echo3g_dsp.c shouldn't include #include <linux/irq.h> Adrian Bunk
2007-01-23 18:24 ` [Alsa-devel] " Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).