LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/11] i386 vDSO: use VM_ALWAYSDUMP
Date: Tue, 23 Jan 2007 12:11:03 -0800 (PST)	[thread overview]
Message-ID: <20070123201103.E4CAD1800E9@magilla.sf.frob.com> (raw)
In-Reply-To: Linus Torvalds's message of  Tuesday, 23 January 2007 11:57:12 -0800 <Pine.LNX.4.64.0701231154030.32200@woody.linux-foundation.org>

> Not that the old code did either, so it's not like it's a new bug, but I 
> thought I'd point it out anyway. As if we care (but you can probably 
> trigger this by having an app that does
> 
> 	munmap(NULL, TASK_SIZE);
>
> which will cause a SIGSEGV on return (because the stack doesn't exist) and 
> then the core-dump should be empty.

Ok, damn you.  I admit I thought of exactly this case and then glossed it
over because I didn't want to complicate the patch and discuss the arcane
justification.  And I was doing a good job of repressing the memory of it
completely before you dredged it up.

> Not that I tested anythign that evil anyway, nor do I think we really care 
> if it means that the gate_vma doesn't get shown in the core-dump either.

I didn't test it either.  And I do sort of think the vDSO should be (the
only thing) in that case's core dump on anal principle.  Now that you've
brought it up, I feel all dirty for ever having sent in code that doesn't
cover the case.  (Not that we really care, since CONFIG_COMPAT_VDSO won't
actually be turned on in practice.)

Starting the loops with "vma = current->mm->mmap ?: gate_vma" should do it.
But I guess Andrew would prefer it:

static struct vm_area_struct *first_vma(struct task_struct *tsk,
					struct vm_area_struct *gate_vma) 
{
	struct vm_area_struct *ret = tsk->mm->mmap;
	if (ret)
		return ret;
	return gate_vma;
}

and:

	for (vma = first_vma(current); vma; vma = next_vma(vma, gate_vma)) {


Thanks,
Roland

  reply	other threads:[~2007-01-23 20:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-14  5:31 [PATCH 1/11] Fix CONFIG_COMPAT_VDSO Roland McGrath
2007-01-14  5:33 ` [PATCH 2/11] Fix gate_vma.vm_flags Roland McGrath
2007-01-14  5:33 ` [PATCH 3/11] Add VM_ALWAYSDUMP Roland McGrath
2007-01-14  5:34 ` [PATCH 4/11] i386 vDSO: use VM_ALWAYSDUMP Roland McGrath
2007-01-23 19:48   ` Andrew Morton
2007-01-23 19:57     ` Linus Torvalds
2007-01-23 20:11       ` Roland McGrath [this message]
2007-01-23 19:57     ` Roland McGrath
2007-01-14  5:34 ` [PATCH 5/11] x86_64 ia32 " Roland McGrath
2007-01-14  5:35 ` [PATCH 6/11] powerpc " Roland McGrath
2007-01-14  5:36 ` [PATCH 7/11] x86_64 ia32 vDSO: define arch_vma_name Roland McGrath
2007-01-14  5:36 ` [PATCH 8/11] Add install_special_mapping Roland McGrath
2007-01-14  5:36 ` [PATCH 9/11] i386 vDSO: use install_special_mapping Roland McGrath
2007-01-14  5:37 ` [PATCH 10/11] x86_64 ia32 " Roland McGrath
2007-01-14  5:37 ` [PATCH 11/11] powerpc " Roland McGrath
2007-01-17  8:49 ` [PATCH 1/11] Fix CONFIG_COMPAT_VDSO Ingo Molnar
2007-01-17  9:03   ` Roland McGrath
2007-01-24 10:25     ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070123201103.E4CAD1800E9@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH 4/11] i386 vDSO: use VM_ALWAYSDUMP' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).