LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 0/1] V4L/DVB fix
@ 2007-01-24 2:47 Mauro Carvalho Chehab
2007-01-24 2:54 ` [PATCH 1/1] V4L/DVB (5123): Buf_qbuf: fix: videobuf_queue->stream corruption and lockup Mauro Carvalho Chehab
0 siblings, 1 reply; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2007-01-24 2:47 UTC (permalink / raw)
To: Linus Torvalds; +Cc: V4L-DVB Maintainers, V4L, Andrew Morton, LKML
Linus,
Please pull 'master' from:
git://git.kernel.org:/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git
master.
The patch fixes an important bug on V4L core. By doing some ioctls on an
unexpected order, it is possible to hang the machine without needing to be
root, causing a DoS.
- Buf_qbuf: fix: videobuf_queue->stream corruption and lockup
This patch should also be applied also at -stable releases.
Cheers,
Mauro.
V4L/DVB development is hosted at http://linuxtv.org
---
drivers/media/video/video-buf.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 1/1] V4L/DVB (5123): Buf_qbuf: fix: videobuf_queue->stream corruption and lockup
2007-01-24 2:47 [PATCH 0/1] V4L/DVB fix Mauro Carvalho Chehab
@ 2007-01-24 2:54 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2007-01-24 2:54 UTC (permalink / raw)
To: LKML; +Cc: V4L-DVB Maintainers, Oleg Nesterov, Mauro Carvalho Chehab
From: Oleg Nesterov <oleg@tv-sign.ru>
We are doing ->buf_prepare(buf) before adding buf to q->stream list. This
means that videobuf_qbuf() should not try to re-add a STATE_PREPARED buffer.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---
drivers/media/video/video-buf.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/video-buf.c b/drivers/media/video/video-buf.c
index 635d102..6504a58 100644
--- a/drivers/media/video/video-buf.c
+++ b/drivers/media/video/video-buf.c
@@ -700,6 +700,7 @@ videobuf_qbuf(struct videobuf_queue *q,
goto done;
}
if (buf->state == STATE_QUEUED ||
+ buf->state == STATE_PREPARED ||
buf->state == STATE_ACTIVE) {
dprintk(1,"qbuf: buffer is already queued or active.\n");
goto done;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-01-24 2:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-24 2:47 [PATCH 0/1] V4L/DVB fix Mauro Carvalho Chehab
2007-01-24 2:54 ` [PATCH 1/1] V4L/DVB (5123): Buf_qbuf: fix: videobuf_queue->stream corruption and lockup Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).