LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* drivers/base: device_bind_driver() fix
@ 2007-01-24 14:14 Vitaly Bordug
  2007-01-24 23:42 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Vitaly Bordug @ 2007-01-24 14:14 UTC (permalink / raw)
  To: Greg KH; +Cc: lkml, Andrew Morton

[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]


Keeps sysfs from creating link if device is already bound to driver.
Similar behavior was before the rework; now without this patch fixed
PHY will complain about not been able to create file in sysfs.

Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
---

 drivers/base/dd.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 510e788..6da3d01 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -26,12 +26,12 @@
 #define to_drv(node) container_of(node, struct device_driver, kobj.entry)
 
 
-static void driver_bound(struct device *dev)
+static int driver_bound(struct device *dev)
 {
 	if (klist_node_attached(&dev->knode_driver)) {
 		printk(KERN_WARNING "%s: device %s already bound\n",
 			__FUNCTION__, kobject_name(&dev->kobj));
-		return;
+		return 0;
 	}
 
 	pr_debug("bound device '%s' to driver '%s'\n",
@@ -42,6 +42,7 @@ static void driver_bound(struct device *dev)
 					     BUS_NOTIFY_BOUND_DRIVER, dev);
 
 	klist_add_tail(&dev->knode_driver, &dev->driver->klist_devices);
+	return 1;
 }
 
 static int driver_sysfs_add(struct device *dev)
@@ -86,7 +87,8 @@ static void driver_sysfs_remove(struct device *dev)
  */
 int device_bind_driver(struct device *dev)
 {
-	driver_bound(dev);
+	if (!driver_bound(dev))
+		return 0;
 	return driver_sysfs_add(dev);
 }
 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: drivers/base: device_bind_driver() fix
  2007-01-24 14:14 drivers/base: device_bind_driver() fix Vitaly Bordug
@ 2007-01-24 23:42 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2007-01-24 23:42 UTC (permalink / raw)
  To: Vitaly Bordug; +Cc: lkml, Andrew Morton

On Wed, Jan 24, 2007 at 05:14:41PM +0300, Vitaly Bordug wrote:
> 
> Keeps sysfs from creating link if device is already bound to driver.
> Similar behavior was before the rework;

Which "rework" caused this?

> now without this patch fixed PHY will complain about not been able to
> create file in sysfs.

Which device is being bound to a driver before it is registered?  I know
the i2c layer does it, but I haven't had any people reporting issues
there.

> Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
> ---
> 
>  drivers/base/dd.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 510e788..6da3d01 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -26,12 +26,12 @@
>  #define to_drv(node) container_of(node, struct device_driver, kobj.entry)
>  
>  
> -static void driver_bound(struct device *dev)
> +static int driver_bound(struct device *dev)
>  {
>  	if (klist_node_attached(&dev->knode_driver)) {
>  		printk(KERN_WARNING "%s: device %s already bound\n",
>  			__FUNCTION__, kobject_name(&dev->kobj));
> -		return;
> +		return 0;
>  	}
>  
>  	pr_debug("bound device '%s' to driver '%s'\n",
> @@ -42,6 +42,7 @@ static void driver_bound(struct device *dev)
>  					     BUS_NOTIFY_BOUND_DRIVER, dev);
>  
>  	klist_add_tail(&dev->knode_driver, &dev->driver->klist_devices);
> +	return 1;

Please return 0 for "good" and -ERRORSOMETHING for a when a problem
happens, like the rest of the kernel.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-01-24 23:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-24 14:14 drivers/base: device_bind_driver() fix Vitaly Bordug
2007-01-24 23:42 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).