LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: S?bastien Dugu? <sebastien.dugue@bull.net>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-aio <linux-aio@kvack.org>,
	Bharata B Rao <bharata@in.ibm.com>,
	Christoph Hellwig <hch@infradead.org>,
	Suparna Bhattacharya <suparna@in.ibm.com>,
	Ulrich Drepper <drepper@redhat.com>,
	Zach Brown <zach.brown@oracle.com>,
	Jean Pierre Dion <jean-pierre.dion@bull.net>,
	Badari Pulavarty <pbadari@us.ibm.com>
Subject: Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification
Date: Thu, 25 Jan 2007 05:42:42 +0000	[thread overview]
Message-ID: <20070125054242.GA8799@infradead.org> (raw)
In-Reply-To: <20070124121130.0dfc8573@frecb000686>

On Wed, Jan 24, 2007 at 12:11:30PM +0100, S?bastien Dugu? wrote:
> > > +	if (unlikely(!notify->sigq))
> > > +		return -EAGAIN;
> > 
> > Did this just leak a ref on the task_struct?
> > 
> 
>   No, the ref is released in really_put_req() when we dispose of
> the iocb.

And the code really needs a comment explaining this.  I tripped over
this before, and I think it's even already the second time Andrew
stumbled over it.


  reply	other threads:[~2007-01-25  5:42 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070117104601.36b2ab18@frecb000686>
2007-01-17  9:48 ` [PATCH -mm 1/5][AIO] - Rework compat_sys_io_submit Sébastien Dugué
2007-01-17  9:48 ` [PATCH -mm 2/5][AIO] - fix aio.h includes Sébastien Dugué
2007-01-17  9:49 ` [PATCH -mm 3/5][AIO] - Make good_sigevent non-static Sébastien Dugué
2007-01-17  9:50 ` [PATCH -mm 4/5][AIO] - AIO completion signal notification Sébastien Dugué
2007-01-24  5:35   ` Andrew Morton
2007-01-24 11:11     ` Sébastien Dugué
2007-01-25  5:42       ` Christoph Hellwig [this message]
2007-01-25  8:46         ` Sébastien Dugué
2007-01-17  9:55 ` [PATCH -mm 5/5][AIO] - Add listio syscall support Sébastien Dugué
2007-01-24  5:50   ` Andrew Morton
2007-01-24 11:51     ` Sébastien Dugué
2007-01-24  5:53   ` Andrew Morton
2007-01-24  9:52     ` Laurent Vivier
2007-01-24 11:53       ` Sébastien Dugué
2007-01-24  6:04   ` Andrew Morton
2007-01-24 12:02     ` Sébastien Dugué
2007-01-24 18:16     ` Bharata B Rao
2006-11-30 15:38 [PATCH -mm 0/5][AIO] - AIO completion signal notification v4 Sébastien Dugué
2006-11-30 15:50 ` [PATCH -mm 4/5][AIO] - AIO completion signal notification Sébastien Dugué
  -- strict thread matches above, loose matches on Subject: below --
2006-11-29 10:24 [PATCH -mm 0/5][AIO] - AIO completion signal notification v3 Sébastien Dugué
2006-11-29 10:33 ` [PATCH -mm 4/5][AIO] - AIO completion signal notification Sébastien Dugué
2006-11-29 10:51   ` Christoph Hellwig
2006-11-29 13:08     ` Sébastien Dugué
2006-11-29 13:50       ` Christoph Hellwig
2006-11-29 14:18         ` Sébastien Dugué
2006-11-29 11:33   ` Jakub Jelinek
2006-11-29 13:25     ` Sébastien Dugué

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070125054242.GA8799@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@osdl.org \
    --cc=bharata@in.ibm.com \
    --cc=drepper@redhat.com \
    --cc=jean-pierre.dion@bull.net \
    --cc=linux-aio@kvack.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbadari@us.ibm.com \
    --cc=sebastien.dugue@bull.net \
    --cc=suparna@in.ibm.com \
    --cc=zach.brown@oracle.com \
    --subject='Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).