LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH -mm] AIO - Comment aio_setup_sigevent() explaining why there is no task ref leak
@ 2007-01-25  9:01 Sébastien Dugué
  0 siblings, 0 replies; only message in thread
From: Sébastien Dugué @ 2007-01-25  9:01 UTC (permalink / raw)
  To: Andrew Morton
  Cc: linux-kernel, linux-aio, Bharata B Rao, Christoph Hellwig,
	Suparna Bhattacharya, Ulrich Drepper, Zach Brown,
	Badari Pulavarty, Jean Pierre Dion


  Here it is

On Thu, 25 Jan 2007 05:42:42 +0000 Christoph Hellwig <hch@infradead.org> wrote:

> On Wed, Jan 24, 2007 at 12:11:30PM +0100, S?bastien Dugu? wrote:
> > > > +	if (unlikely(!notify->sigq))
> > > > +		return -EAGAIN;
> > > 
> > > Did this just leak a ref on the task_struct?
> > > 
> > 
> >   No, the ref is released in really_put_req() when we dispose of
> > the iocb.
> 
> And the code really needs a comment explaining this.  I tripped over
> this before, and I think it's even already the second time Andrew
> stumbled over it.
> 

From: Sébastien Dugué <sebastien.dugue@bull.net>

  Add a comment explaining why there is no task ref leak in
aio_setup_sigevent().


 aio.c |    5 +++++
 1 file changed, 5 insertions(+)


Signed-off-by: Sébastien Dugué <sebastien.dugue@bull.net>

Index: linux-2.6.20-rc4-mm1/fs/aio.c
===================================================================
--- linux-2.6.20-rc4-mm1.orig/fs/aio.c	2007-01-17 08:59:16.000000000 +0100
+++ linux-2.6.20-rc4-mm1/fs/aio.c	2007-01-25 09:52:29.000000000 +0100
@@ -987,6 +987,11 @@ static long aio_setup_sigevent(struct ai
 	 */
 	notify->sigq = sigqueue_alloc();
 
+	/*
+	 * The task ref will be released in really_put_req()
+	 * when we dispose of the iocb later on in the submission
+	 * path.
+	 */
 	if (unlikely(!notify->sigq))
 		return -EAGAIN;
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-01-25  9:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-25  9:01 [PATCH -mm] AIO - Comment aio_setup_sigevent() explaining why there is no task ref leak Sébastien Dugué

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).