LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Rainer Weikusat <rainer.weikusat@sncag.com>
Cc: torvalds@linux-foundation.org, bunk@stusta.de,
	linux-kernel@vger.kernel.org
Subject: Re: unfixed regression in 2.6.20-rc6 (since 2.6.19)
Date: Thu, 25 Jan 2007 10:51:01 -0800	[thread overview]
Message-ID: <20070125185101.GA26279@kroah.com> (raw)
In-Reply-To: <877ivb2kvc.fsf@semtex.sncag.com>

On Thu, Jan 25, 2007 at 04:20:55PM +0100, Rainer Weikusat wrote:
> 2.6.19 introduced changes to the UHCI handling of interrupt URBs that
> caused at least some keyspan USB-to-serial converters to fail, because
> the driver code incorrectly assumes that all URBs of the device are
> bulk URBs, while some of them (in the default configuration) are
> actually interrupt URBs. This has been reported via kernel bugzilla as
> bug 7544 on 2006/11/17:
> 
> 	http://bugzilla.kernel.org/show_bug.cgi?id=7544
> 
> I happen to use such a device, but I didn't have the time to deal with
> this issue until end of december. A fix for this regression has been
> available at least since 2006/12/26. The patch available via bugzilla
> has been reworked by me because of comments from Mr. Kroah-Hartmann,
> 
> 	http://marc.theaimsgroup.com/?l=linux-kernel&m=116783507105717&w=2
> 
> It has been part of the -mm tree until about three days ago and was
> then dropped by Andrew Morton because Mr Kroah-Hartmann added a
> structurally identical and functionally neutral (or slightly worse)
> rewritten-by-him version of it to something called 'gregkh-2.6',
> presumably, judging from the age of other patches in this particular
> tree (back until 2006/09/19), to never see the light of the day again.

Huh?  That's my staging tree for what goes to Linus and Andrew.

Yes, some patches in there are very old, and are not supposed to ever go
to mainline, but that is the minority.

I copied you when this patch was added to my tree, as I had reworked it
to be a bit more acceptable (no pointer arithmatic, proper coding style,
use the newer macros for endpoint detection, etc.), so you were aware
when this change was added.  If this patch does not work, please let me
know, and I will be glad to work to fix it.

thanks,

greg k-h

  reply	other threads:[~2007-01-25 18:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-25 15:20 Rainer Weikusat
2007-01-25 18:51 ` Greg KH [this message]
2007-01-26 10:43   ` Rainer Weikusat
2007-01-26 17:48     ` Greg KH
2007-01-28 13:34       ` Rainer Weikusat
2007-01-29  1:22         ` Oleg Verych
2007-01-29 23:43           ` Greg KH
2007-01-30 17:40             ` Rainer Weikusat
2007-02-04  4:39               ` Greg KH
2007-02-12 14:30                 ` Rainer Weikusat
2007-02-12 16:37                   ` Greg KH
2007-02-12 17:10                     ` Rainer Weikusat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070125185101.GA26279@kroah.com \
    --to=greg@kroah.com \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rainer.weikusat@sncag.com \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: unfixed regression in 2.6.20-rc6 (since 2.6.19)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).