LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Blaisorblade <blaisorblade@yahoo.it>
To: user-mode-linux-devel@lists.sourceforge.net
Cc: Andrew Morton <akpm@osdl.org>, Jeff Dike <jdike@karaya.com>,
	Johannes Stezenbach <js@linuxtv.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [uml-devel] [PATCH] [UML] fix mknod
Date: Fri, 26 Jan 2007 19:49:56 +0100	[thread overview]
Message-ID: <200701261949.57042.blaisorblade@yahoo.it> (raw)
In-Reply-To: <20070124203126.36e78674.akpm@osdl.org>

On Thursday 25 January 2007 05:31, Andrew Morton wrote:
> On Tue, 23 Jan 2007 23:33:29 +0100
>
> Blaisorblade <blaisorblade@yahoo.it> wrote:
> > On Tuesday 23 January 2007 14:17, Johannes Stezenbach wrote:
> > > On Tue, Jan 23, 2007 at 09:02:30AM +0100, Blaisorblade wrote:
> > > > On Monday 22 January 2007 21:13, Johannes Stezenbach wrote:
> > > > > I was playing with user-mode Linux and found that mknod creates
> > > > > devices node in hostfs with wrong major/minor numbers.
> > > > > The patch below fixes it for me.
> > > >
> > > > Hmpf. Still having this bug on hostfs is quite bad. Thanks for
> > > > reporting.
> >
> > I've now seen - we never fixed this one, we fixed the analogous problem
> > on 'ls' output and friends (in init_inode, which is used in many places).
> >
> > > > It should be hostfs_user.c to take major and minor and to combine
> > > > them correctly - it can use libc's macros.
> > >
> > > Right, below is a better patch.
> >
> > Exactly what I meant, thanks!
> > I'd say:
> > Acked-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
> > This can go to 2.6.20, and possibly even to -stable (after either me or
> > Jeff tests it once).

> So..  did you test it?

Just tested, I could reproduce the bug and verify the fix works, on 2.6.18; 
and for me it's enough to merge it, considering that little changes happened 
on hostfs, and because it's well understood with static review that this fix 
is needed.

It should also be merged in 2.6.16-stable.
-- 
Inform me of my mistakes, so I can add them to my list!
Paolo Giarrusso, aka Blaisorblade
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale! 
 http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com 

      reply	other threads:[~2007-01-26 18:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-22 20:13 Johannes Stezenbach
2007-01-23  8:02 ` [uml-devel] " Blaisorblade
2007-01-23 13:17   ` Johannes Stezenbach
2007-01-23 22:33     ` Blaisorblade
2007-01-25  4:31       ` Andrew Morton
2007-01-26 18:49         ` Blaisorblade [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200701261949.57042.blaisorblade@yahoo.it \
    --to=blaisorblade@yahoo.it \
    --cc=akpm@osdl.org \
    --cc=jdike@karaya.com \
    --cc=js@linuxtv.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    --subject='Re: [uml-devel] [PATCH] [UML] fix mknod' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).