LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: jmoyer@redhat.com
Cc: Jan Engelhardt <jengelh@linux01.gwdg.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Steven Fernandez <sfernand@redhat.com>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [patch] raw: don't allow the creation of a raw device with minor number 0
Date: Sun, 28 Jan 2007 15:23:37 -0500	[thread overview]
Message-ID: <20070128202336.GA23903@redhat.com> (raw)
In-Reply-To: <m38xg73l9a.fsf@redhat.com>

On Fri, Jan 12, 2007 at 05:58:41PM -0500, jmoyer@redhat.com wrote:
 > ==> Regarding Re: [patch] raw: don't allow the creation of a raw device with minor number 0; Jan Engelhardt <jengelh@linux01.gwdg.de> adds:
 > 
 > jengelh> On Jan 12 2007 11:32, Jeff Moyer wrote:
 > 
 > >> Minor number 0 (under the raw major) is reserved for the rawctl device
 > >> file, which is used to query, set, and unset raw device bindings.
 > >> However, the ioctl interface does not protect the user from specifying
 > >> a raw device with minor number 0:
 > 
 > jengelh> No idea what to say about this... probably:
 > 
 > jengelh>   What:   RAW driver (CONFIG_RAW_DRIVER)
 > jengelh>   When:   December 2005
 > jengelh>   Why:    declared obsolete since kernel 2.6.3
 > jengelh>           O_DIRECT can be used instead
 > jengelh>   Who:    Adrian Bunk <bunk@stusta.de>
 > 
 > It's still present, still used, and so would benefit from being fixed, in
 > my opinion.

Given the tirade against O_DIRECT on linux-kernel earlier this month,
it has me wondering about the validity of this entry.

Every time we've tried to deprecate this driver in Fedora/RHEL, we've
had enough people complain that we've ended up having to turn it back on.
(And I'm fairly sure other distros have been in the same position).
Some vendors seem way too attached to the older semantics than having
to rewrite their apps to use O_DIRECT, and unnecessarily breaking them
so that we can throw away a 306 line driver in the name of cleanliness
seems a bit gratuitous.

		Dave

-- 
http://www.codemonkey.org.uk

  reply	other threads:[~2007-01-28 20:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-12 16:32 Jeff Moyer
2007-01-12 22:41 ` Jan Engelhardt
2007-01-12 22:58   ` jmoyer
2007-01-28 20:23     ` Dave Jones [this message]
     [not found] <7CxBM-2pk-23@gated-at.bofh.it>
     [not found] ` <7CDnP-30W-9@gated-at.bofh.it>
     [not found]   ` <7CDxA-3cL-9@gated-at.bofh.it>
     [not found]     ` <7IoP7-5nQ-13@gated-at.bofh.it>
2007-01-30 15:52       ` Bodo Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070128202336.GA23903@redhat.com \
    --to=davej@redhat.com \
    --cc=akpm@osdl.org \
    --cc=jengelh@linux01.gwdg.de \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfernand@redhat.com \
    --subject='Re: [patch] raw: don'\''t allow the creation of a raw device with minor number 0' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).