LKML Archive on
help / color / mirror / Atom feed
From: Alan Cox <>
To: Christoph Hellwig <>
Subject: Re: [PATCH] tty: cleanup release_mem
Date: Mon, 29 Jan 2007 07:01:00 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sun, Jan 28, 2007 at 06:12:44PM +0100, Christoph Hellwig wrote:
> release_mem contains two copies of exactly the same code.  Refactor
> these into a new helper, release_tty.  The only change in behaviour
> is that the driver reference count is now decremented after the
> master tty has been freed instead of before.
> Signed-off-by: Christoph Hellwig <>

Acked-by: Alan Cox <>

Please propogate the mutex_ FIXME comment to both functions as it may
well need to cover tty->link

  reply	other threads:[~2007-01-29 12:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-28 17:12 Christoph Hellwig
2007-01-29 12:01 ` Alan Cox [this message]
2007-01-29 18:12   ` Christoph Hellwig
2007-01-29 19:06     ` Alan Cox
2007-01-30  3:56       ` Andrew Morton
2007-01-30  6:33         ` Pekka Enberg
2007-01-31  7:16 Pekka J Enberg
2007-01-31 14:20 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \
    --subject='Re: [PATCH] tty: cleanup release_mem' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).