LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Konstantin Kletschke <lists@ku-gbr.de>
To: linux-kernel@vger.kernel.org
Cc: s.hauer@pengutronix.de, ppisa4lists@pikron.com
Subject: Re: ARM i.MX serial: fix tx buffer overflows
Date: Mon, 29 Jan 2007 15:47:59 +0100	[thread overview]
Message-ID: <20070129144758.GA2760@synertronixx3> (raw)
In-Reply-To: <200701051901.52486.ppisa4lists@pikron.com>

Am 2007-01-05 19:01 +0100 schrieb Pavel Pisa:

> It applies only for interrupts going through GPIO layer.
> The problem has been noticed by Konstantin Kletschke
> some time ago.
> 
>   No IRQF_TRIGGER set_type function for IRQ 26 (MPU)

Yes. I reported this also.

>  drivers/serial/imx.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Index: linux-2.6.19-rt/drivers/serial/imx.c
> ===================================================================
> +++ linux-2.6.19-rt/drivers/serial/imx.c
> @@ -403,7 +403,8 @@ static int imx_startup(struct uart_port 
>  	if (retval) goto error_out2;
>  
>  	retval = request_irq(sport->rtsirq, imx_rtsint,
> -			     IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
> +			     (sport->rtsirq < IMX_IRQS) ? 0 :
> +			       IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
>  			     DRIVER_NAME, sport);
>  	if (retval) goto error_out3;


Okay, this indeed fixes my

No IRQF_TRIGGER set_type function for IRQ 26 (MPU)

here!

Regards, Konsti

-- 
GPG KeyID EF62FCEF
Fingerprint: 13C9 B16B 9844 EC15 CC2E  A080 1E69 3FDA EF62 FCEF

  reply	other threads:[~2007-01-29 15:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-05 15:51 ARM i.MX serial: fix tx buffer overflows Sascha Hauer
2007-01-05 18:01 ` Pavel Pisa
2007-01-29 14:47   ` Konstantin Kletschke [this message]
2007-01-29 15:37     ` Russell King
2007-01-29 16:43       ` Konstantin Kletschke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070129144758.GA2760@synertronixx3 \
    --to=lists@ku-gbr.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ppisa4lists@pikron.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).