LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [patch] use __u32 in asm-x86_64/msr.h
@ 2007-01-30  0:25 Mike Frysinger
  2007-01-30  3:55 ` Dave Jones
  0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2007-01-30  0:25 UTC (permalink / raw)
  To: ak; +Cc: linux-kernel


[-- Attachment #1.1: Type: text/plain, Size: 166 bytes --]

the checking_wrmsrl() macro in asm-x86_64/msr.h which is exported to userspace 
utilizes the u32 type instead of __u32 ... trivial attached patch fixes that
-mike

[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]

[-- Attachment #2: linux-use-__-types-in-x86-64-msr.patch --]
[-- Type: text/x-diff, Size: 738 bytes --]

Use __u32 rather than u32 in checking_wrmsrl() exported to userspace.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

--- a/include/asm-x86_64/msr.h
+++ b/include/asm-x86_64/msr.h
@@ -2,6 +2,9 @@
 #define X86_64_MSR_H 1
 
 #ifndef __ASSEMBLY__
+
+#include <linux/types.h>
+
 /*
  * Access to machine-specific registers (available on 586 and better only)
  * Note: the rd* operations modify the parameters directly (without using
@@ -43,7 +46,7 @@
 		     : "c" (msr), "0" (a), "d" (b), "i" (-EFAULT)); \
 	ret__; })
 
-#define checking_wrmsrl(msr,val) wrmsr_safe(msr,(u32)(val),(u32)((val)>>32))
+#define checking_wrmsrl(msr,val) wrmsr_safe(msr,(__u32)(val),(__u32)((val)>>32))
 
 #define rdmsr_safe(msr,a,b) \
 	({ int ret__;						\

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch] use __u32 in asm-x86_64/msr.h
  2007-01-30  0:25 [patch] use __u32 in asm-x86_64/msr.h Mike Frysinger
@ 2007-01-30  3:55 ` Dave Jones
  0 siblings, 0 replies; 2+ messages in thread
From: Dave Jones @ 2007-01-30  3:55 UTC (permalink / raw)
  To: Mike Frysinger; +Cc: ak, linux-kernel

On Mon, Jan 29, 2007 at 07:25:08PM -0500, Mike Frysinger wrote:
 > the checking_wrmsrl() macro in asm-x86_64/msr.h which is exported to userspace 
 > utilizes the u32 type instead of __u32 ... trivial attached patch fixes that

Better would be to not export those macros to userspace at all,
as they can't be used outside of ring 0 anyway.

		Dave

-- 
http://www.codemonkey.org.uk

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-01-30  3:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-30  0:25 [patch] use __u32 in asm-x86_64/msr.h Mike Frysinger
2007-01-30  3:55 ` Dave Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).