LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: "Frédéric Riss" <frederic.riss@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>,
	andi@lisas.de, davej@codemonkey.org.uk,
	kernel list <linux-kernel@vger.kernel.org>,
	seife@suse.de, Wang Zhenyu <zhenyu.z.wang@intel.com>
Subject: Re: i965 testers wanted (Re: intel-agp PM experiences)
Date: Mon, 29 Jan 2007 17:34:28 -0500	[thread overview]
Message-ID: <20070129223428.GL9363@redhat.com> (raw)
In-Reply-To: <1170109291.21603.15.camel@funkylaptop>

On Mon, Jan 29, 2007 at 11:21:31PM +0100, Frédéric Riss wrote:
 > Le lundi 29 janvier 2007 à 23:10 +0100, Pavel Machek a écrit :
 > > > > Ok, I guess we'd like some testing here... so that in can be fixed in
 > > > > mainline...
 > > > 
 > > > I can confirm that this patch is needed for my Intel Mac Mini to resume
 > > > correctly when used without BIOS emulation (EFI mode). Here're the
 > > > relevant lspci lines:
 > > 
 > > Can you attach the patch you tested (there was link above, but it did
 > > not work for me), and try pushing it through maintainers?
 > 
 > I inlined the patch I used below. If I'm not mistaken, the maintainer is
 > Davej which is already in the Cc: list. I think it's exactly the same as
 > was submitted in http://lkml.org/lkml/2007/1/16/297 (I may have hand
 > copied it though, can't remember). The above link is more complete as it
 > contains the Signed-off-by and a description.
 > 
 > diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
 > index ab0a9c0..f64a115 100644
 > --- a/drivers/char/agp/intel-agp.c
 > +++ b/drivers/char/agp/intel-agp.c
 > @@ -1955,6 +1955,15 @@ static int agp_intel_resume(struct pci_d
 >  
 >  	pci_restore_state(pdev);
 >  
 > +	/* We should restore our graphics device's config space,
 > +	 * as host bridge (00:00) resumes before graphics device (02:00),
 > +	 * then our access to its pci space can work right. 
 > +	 */
 > +	if (intel_i810_private.i810_dev)
 > +		pci_restore_state(intel_i810_private.i810_dev);
 > +	if (intel_i830_private.i830_dev)
 > +		pci_restore_state(intel_i830_private.i830_dev);

This has been in agpgart.git since the 17th.
I asked Linus to pull last night.

		Dave

-- 
http://www.codemonkey.org.uk

  reply	other threads:[~2007-01-29 22:34 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-16 13:57 2.6.20-rc5: usb mouse breaks suspend to ram Pavel Machek
2007-01-16 14:08 ` Dmitry Torokhov
2007-01-16 14:24   ` Pavel Machek
2007-01-16 21:25     ` Dmitry Torokhov
2007-01-16 21:47       ` Pavel Machek
2007-01-17 15:44         ` [linux-usb-devel] " Alan Stern
2007-01-17  0:40       ` Andreas Mohr
2007-01-17  0:57         ` Pavel Machek
2007-01-18 11:51           ` intel-agp PM experiences (was: 2.6.20-rc5: usb mouse breaks suspend to ram) Andreas Mohr
2007-01-18 22:05             ` Nigel Cunningham
2007-01-18 23:16             ` Pavel Machek
2007-01-22  4:45               ` Wang Zhenyu
2007-01-23  9:44                 ` i965 testers wanted (Re: intel-agp PM experiences) Pavel Machek
2007-01-23 14:46                   ` Sunil Naidu
2007-01-29 22:05                   ` Frédéric Riss
2007-01-29 22:10                     ` Pavel Machek
2007-01-29 22:21                       ` Frédéric Riss
2007-01-29 22:34                         ` Dave Jones [this message]
2007-01-29 21:30                 ` intel-agp PM experiences (was: 2.6.20-rc5: usb mouse breaks suspend to ram) Andreas Mohr
2007-01-30 12:36                   ` Wang Zhenyu
2007-01-30 13:05                     ` Andreas Mohr
2007-01-30 23:39                     ` Andreas Mohr
2007-05-01 14:59               ` [PATCH -mm] working 3D/DRI intel-agp.ko resume for i815 chip; Intel chipset testers wanted! (was: Re: intel-agp PM experiences ...) Andreas Mohr
2007-05-02 10:17                 ` Pavel Machek
2007-05-03 15:47                   ` Dave Jones
2007-05-05 17:56                   ` Andreas Mohr
2007-05-10  6:44                     ` Andreas Mohr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070129223428.GL9363@redhat.com \
    --to=davej@redhat.com \
    --cc=andi@lisas.de \
    --cc=davej@codemonkey.org.uk \
    --cc=frederic.riss@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=seife@suse.de \
    --cc=zhenyu.z.wang@intel.com \
    --subject='Re: i965 testers wanted (Re: intel-agp PM experiences)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).