LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sergey Vlasov <vsu@altlinux.ru>
To: Jean Delvare <jdelvare@suse.de>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Daniel Drake <dsd@reactivated.net>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Adrian Bunk <bunk@stusta.de>
Subject: Re: via irq quirk breakage
Date: Tue, 30 Jan 2007 14:47:01 +0300	[thread overview]
Message-ID: <20070130144701.e793c222.vsu@altlinux.ru> (raw)
In-Reply-To: <200701300854.06083.jdelvare@suse.de>

[-- Attachment #1: Type: text/plain, Size: 1613 bytes --]

On Tue, 30 Jan 2007 08:54:05 +0100 Jean Delvare wrote:

> You have an old VT82C686 south bridge, which was tagged as "special" by
> Alan. For this chip, Alan's code only allows devices 00:00.x to be quirked.
> As my code was merely a reimplementation of Alan's idea, it does the same.
> Your USB controllers are at 00:07.x, so I'm not surprised they weren't
> quirked.
>
> Alan, why were dev_lo and dev_hi both set to 0 for the VT82C868 in your
> implementation? Is it a typo, or...?
>
> Nick, I guess the following patch would work better for you? I've listed
> devices 00:07.x as quirkable for the VT82C686.

The VT82C686 is very different from other devices, because it is
a PCI chip, and its device number is determined by IDSEL wiring.
Google shows that several different assignments are in use:

00:01.0:
http://ozlabs.org/pipermail/linuxppc-embedded/2005-January/016642.html
(but that's PPC)

00:04.0: http://www.cs.helsinki.fi/linux/linux-kernel/2001-36/0083.html
00:05.0: http://lkml.org/lkml/2003/12/11/78
00:07.0: this example and lots of other links
00:14.0: http://forum.freespire.org/showthread.php?t=2998

> +static void quirk_via_bridge(struct pci_dev *dev)
> +{
> +	/* See what bridge we have and find the device ranges */
> +	switch (dev->device) {
> +	case PCI_DEVICE_ID_VIA_82C686:
> +		/* 82C686 is special */
> +		via_vlink_dev_lo = 7;
> +		via_vlink_dev_hi = 7;

So this should probably be:

		/*
		 * 82C686 attaches to PCI and can have any device number, but
		 * all its subdevices are functions of that single device.
		 */
		via_vlink_dev_lo = via_vlink_dev_hi = PCI_SLOT(dev->devfn);

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2007-01-30 11:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-24  0:33 Nick Piggin
2007-01-29 15:00 ` Jean Delvare
2007-01-29 15:51   ` Alan
2007-01-30 12:29     ` Jean Delvare
2007-01-30 16:05       ` Alan
2007-01-30  2:35   ` Nick Piggin
2007-01-30  7:54     ` Jean Delvare
2007-01-30  8:32       ` Nick Piggin
2007-01-30 11:47       ` Sergey Vlasov [this message]
2007-01-30 12:25         ` [PATCH] VIA IRQ quirk breakage fix Jean Delvare
2007-01-30 13:38           ` Nick Piggin
2007-01-30 13:49             ` Jean Delvare
2007-01-30 16:21               ` Alan
2007-01-30 16:17                 ` Jean Delvare
2007-01-30 18:02               ` Andrew Morton
2007-01-31  2:37           ` Andrew Morton
2007-02-01  7:39             ` Jean Delvare
2007-01-30 14:56       ` via irq quirk breakage Alan
2007-01-30 14:50         ` Jeff Garzik
2007-01-30 14:25     ` Alan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070130144701.e793c222.vsu@altlinux.ru \
    --to=vsu@altlinux.ru \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bunk@stusta.de \
    --cc=dsd@reactivated.net \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --subject='Re: via irq quirk breakage' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).