LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Daniel Walker <dwalker@mvista.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, johnstul@us.ibm.com
Subject: [PATCH 08/23] clocksource: drop duplicate register checking
Date: Tue, 30 Jan 2007 19:37:18 -0800	[thread overview]
Message-ID: <20070131033805.498958666@mvista.com> (raw)
In-Reply-To: 20070131033710.420168478@mvista.com

[-- Attachment #1: clocksource_list_init.patch --]
[-- Type: text/plain, Size: 1468 bytes --]

This is something Thomas already dropped, and I'm just sticking
with that .. If you register your clocksource _twice_ your kernel will
likely not work correctly (and might crash).

Signed-Off-By: Daniel Walker <dwalker@mvista.com>

---
 kernel/time/clocksource.c |   19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

Index: linux-2.6.19/kernel/time/clocksource.c
===================================================================
--- linux-2.6.19.orig/kernel/time/clocksource.c
+++ linux-2.6.19/kernel/time/clocksource.c
@@ -186,16 +186,12 @@ int clocksource_register(struct clocksou
 	unsigned long flags;
 
 	spin_lock_irqsave(&clocksource_lock, flags);
-	if (unlikely(!list_empty(&c->list) && __is_registered(c->name))) {
-		printk("register_clocksource: Cannot register %s clocksource. "
-		       "Already registered!", c->name);
-		ret = -EBUSY;
-	} else {
-		INIT_LIST_HEAD(&c->list);
- 		__sorted_list_add(c);
-		/* scan the registered clocksources, and pick the best one */
-		next_clocksource = select_clocksource();
-	}
+ 	__sorted_list_add(c);
+
+	/*
+	 * scan the registered clocksources, and pick the best one
+	 */
+	next_clocksource = select_clocksource();
 	spin_unlock_irqrestore(&clocksource_lock, flags);
 	return ret;
 }
@@ -212,9 +208,6 @@ void clocksource_rating_change(struct cl
 {
 	unsigned long flags;
 
-	if (unlikely(list_empty(&c->list)))
-		return;
-
   	spin_lock_irqsave(&clocksource_lock, flags);
 
 	/*

-- 

  parent reply	other threads:[~2007-01-31  3:39 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-31  3:37 [PATCH 00/23] clocksource update v12 Daniel Walker
2007-01-31  3:37 ` [PATCH 01/23] clocksource: drop clocksource-add-verification-watchdog-helper-fix.patch Daniel Walker
2007-01-31 12:47   ` Ingo Molnar
2007-01-31  3:37 ` [PATCH 02/23] clocksource: drop clocksource-add-verification-watchdog-helper.patch Daniel Walker
2007-01-31  3:37 ` [PATCH 03/23] clocksource: drop clocksource-remove-the-update-callback.patch Daniel Walker
2007-01-31  3:37 ` [PATCH 04/23] clocksource: drop time-x86_64-tsc-fixup-clocksource-changes.patch Daniel Walker
2007-01-31  3:37 ` [PATCH 05/23] clocksource: drop simplify-the-registration-of-clocksources.patch Daniel Walker
2007-01-31  3:37 ` [PATCH 06/23] timekeeping: create kernel/time/timekeeping.c Daniel Walker
2007-01-31  8:59   ` Ingo Molnar
2007-01-31 15:05     ` Daniel Walker
2007-01-31  3:37 ` [PATCH 07/23] clocksource: rating sorted list Daniel Walker
2007-01-31  9:34   ` Ingo Molnar
2007-01-31 15:07     ` Daniel Walker
2007-01-31  3:37 ` Daniel Walker [this message]
2007-01-31  9:59   ` [PATCH 08/23] clocksource: drop duplicate register checking Ingo Molnar
2007-01-31 15:13     ` Daniel Walker
2007-01-31 17:19       ` Ingo Molnar
2007-01-31  3:37 ` [PATCH 09/23] clocksource: add block notifier Daniel Walker
2007-01-31 10:17   ` Ingo Molnar
2007-01-31 15:25     ` Daniel Walker
2007-01-31 17:22       ` Ingo Molnar
2007-01-31  3:37 ` [PATCH 10/23] clocksource: remove update_callback Daniel Walker
2007-01-31 10:46   ` Ingo Molnar
2007-01-31 15:42     ` Daniel Walker
2007-01-31 17:18       ` Ingo Molnar
2007-01-31  3:37 ` [PATCH 11/23] clocksource: atomic signals Daniel Walker
2007-01-31 11:07   ` Ingo Molnar
2007-01-31 15:59     ` Daniel Walker
2007-01-31 17:15       ` Ingo Molnar
2007-01-31  3:37 ` [PATCH 12/23] clocksource: add clocksource_get_clock() Daniel Walker
2007-01-31 11:46   ` Ingo Molnar
2007-01-31 16:40     ` Daniel Walker
2007-01-31  3:37 ` [PATCH 13/23] timekeeping: move sysfs layer/drop API calls Daniel Walker
2007-01-31 11:49   ` Ingo Molnar
2007-01-31  3:37 ` [PATCH 14/23] clocksource: increase initcall priority Daniel Walker
2007-01-31 11:50   ` Ingo Molnar
2007-01-31 16:42     ` Daniel Walker
2007-01-31 17:10       ` Ingo Molnar
2007-01-31 17:20         ` Daniel Walker
2007-01-31 17:29           ` Thomas Gleixner
2007-01-31  3:37 ` [PATCH 15/23] clocksource: add new flags Daniel Walker
2007-01-31  3:37 ` [PATCH 16/23] clocksource: arm update for " Daniel Walker
2007-01-31 12:27   ` Ingo Molnar
2007-01-31  3:37 ` [PATCH 17/23] clocksource: avr32 " Daniel Walker
2007-01-31  3:37 ` [PATCH 18/23] clocksource: i386 " Daniel Walker
2007-01-31  3:37 ` [PATCH 19/23] clocksource: mips " Daniel Walker
2007-01-31  3:37 ` [PATCH 20/23] clocksource: x86_64 " Daniel Walker
2007-01-31  3:37 ` [PATCH 21/23] clocksource: drivers/ " Daniel Walker
2007-01-31  3:37 ` [PATCH 22/23] clocksource: new clock lookup method Daniel Walker
     [not found]   ` <20070131122215.GE1847@elte.hu>
     [not found]     ` <1170261439.9781.96.camel@imap.mvista.com>
     [not found]       ` <20070131164918.GA4468@elte.hu>
     [not found]         ` <1170265169.9781.145.camel@imap.mvista.com>
2007-01-31 17:55           ` Thomas Gleixner
2007-01-31 18:07             ` Daniel Walker
2007-01-31 21:09               ` Thomas Gleixner
2007-01-31  3:37 ` [PATCH 23/23] clocksource tsc: add verify routine Daniel Walker
2007-01-31 12:43   ` Ingo Molnar
2007-01-31 17:02     ` Daniel Walker
2007-01-31 17:22       ` Thomas Gleixner
2007-01-31 17:33       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070131033805.498958666@mvista.com \
    --to=dwalker@mvista.com \
    --cc=akpm@osdl.org \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).