LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bron Gondwana <brong@fastmail.fm>
To: Adrian Bunk <bunk@stusta.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Mark Lord <lkml@rtr.ca>, Bron Gondwana <brong@fastmail.fm>,
	Mike Houston <mikeserv@bmts.com>,
	Chuck Ebbert <cebbert@redhat.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Steve French <smfltc@us.ibm.com>,
	Dave Kleikamp <shaggy@linux.vnet.ibm.com>,
	Daniel Drake <dsd@gentoo.org>,
	samba-technical@lists.samba.org,
	Vladimir Saveliev <vs@namesys.com>,
	reiserfs-dev@namesys.com, David Chinner <dgc@sgi.com>,
	xfs-masters@oss.sgi.com
Subject: Reiserfs and MMAP (was: How many people are using 2.6.16?)
Date: Wed, 31 Jan 2007 21:42:48 +1100	[thread overview]
Message-ID: <20070131104248.GA14260@brong.net> (raw)
In-Reply-To: <20070131070237.GT3754@stusta.de>

On Wed, Jan 31, 2007 at 08:02:37AM +0100, Adrian Bunk wrote:
> reiserfs:
> commit de14569f94513279e3d44d9571a421e9da1759ae
>   [PATCH] resierfs: avoid tail packing if an inode was ever mmapped
> backport to 2.6.16 required

Which would explain the "notail" I've been careful to cargo-cult
into every mount string since I started at this job, even though
we're storing mainly very small files.

Referring back to: <43BE1EDF.3010305@namesys.com> (which went
to reiserfs-dev and a couple of the ever-growing CC list above)
we're still not 100% sure if it's safe to remove the patch that
I attached there:

>>>>--- file.c~ 2004-10-02 12:29:33.223660850 +0400
>>>>+++ file.c 2004-10-08 10:03:03.001561661 +0400
>>>>@@ -1137,6 +1137,8 @@
>>>>return result;
>>>>  }
>>>>
>>>>+    return generic_file_write(file, buf, count, ppos);
>>>>+
>>>>  if ( unlikely((ssize_t) count < 0 ))
>>>>      return -EINVAL;

which Hans asserted was about 5% slower than the resierfs custom
write implementation, but we countered at least meant that we
didn't crash in a steaming pile of processes stuck in D state
with no way out every few days.

It doesn't apply against 2.6.19 any more, which may be a good
sign.  I haven't seen anything in the changelogs that jumped
out at me as the fix though.

Regards,

Bron.

  reply	other threads:[~2007-01-31 10:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-29 20:30 How many people are using 2.6.16? Chuck Ebbert
2007-01-29 20:35 ` Josh Boyer
2007-01-29 20:38   ` Chuck Ebbert
2007-02-07 20:36     ` Greg KH
2007-01-29 21:04 ` Mike Houston
2007-01-29 22:13   ` Bron Gondwana
2007-01-30 20:39     ` Adrian Bunk
2007-01-31  1:33       ` Mark Lord
2007-01-31  2:36         ` Linus Torvalds
2007-01-31  5:49           ` Bron Gondwana
2007-01-31  7:02           ` Adrian Bunk
2007-01-31 10:42             ` Bron Gondwana [this message]
2007-01-31 11:49             ` David Chinner
2007-01-31 14:34               ` Steve French (smfltc)
2007-01-31 15:34             ` Linus Torvalds
2007-02-01 12:13             ` Vladimir V. Saveliev
2007-02-03  1:39               ` Adrian Bunk
2007-01-30 23:52   ` Adrian Bunk
2007-01-31  1:48     ` Mike Houston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070131104248.GA14260@brong.net \
    --to=brong@fastmail.fm \
    --cc=bunk@stusta.de \
    --cc=cebbert@redhat.com \
    --cc=dgc@sgi.com \
    --cc=dsd@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@rtr.ca \
    --cc=mikeserv@bmts.com \
    --cc=reiserfs-dev@namesys.com \
    --cc=samba-technical@lists.samba.org \
    --cc=shaggy@linux.vnet.ibm.com \
    --cc=smfltc@us.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vs@namesys.com \
    --cc=xfs-masters@oss.sgi.com \
    --subject='Re: Reiserfs and MMAP (was: How many people are using 2.6.16?)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).