LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Chinner <dgc@sgi.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Mark Lord <lkml@rtr.ca>, Bron Gondwana <brong@fastmail.fm>,
	Mike Houston <mikeserv@bmts.com>,
	Chuck Ebbert <cebbert@redhat.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Steve French <smfltc@us.ibm.com>,
	Dave Kleikamp <shaggy@linux.vnet.ibm.com>,
	Daniel Drake <dsd@gentoo.org>,
	samba-technical@lists.samba.org,
	Vladimir Saveliev <vs@namesys.com>,
	reiserfs-dev@namesys.com, David Chinner <dgc@sgi.com>,
	xfs-masters@oss.sgi.com
Subject: Re: How many people are using 2.6.16?
Date: Wed, 31 Jan 2007 22:49:35 +1100	[thread overview]
Message-ID: <20070131114935.GP33919298@melbourne.sgi.com> (raw)
In-Reply-To: <20070131070237.GT3754@stusta.de>

On Wed, Jan 31, 2007 at 08:02:37AM +0100, Adrian Bunk wrote:
> On Tue, Jan 30, 2007 at 06:36:48PM -0800, Linus Torvalds wrote:
> > The issue was somewhat confused by people certainly *reporting* it for 
> > older kernels. Also, as part of the dirty bit cleanups and sanity 
> > checkingwe did actually seem to fix a long-standing CIFS corruption (and 
> > apparently reisertfs/XFS problems too).
> > 
> > But the *common* case was actually introduced with 2.6.19, and 2.6.16 
> > wouldn't be affected. 
> 
> Thanks for the clarifications.
> 
> Regarding the longstanding CIFS/reiserfs/XFS problems, it seems the 
> status is:
....
> XFS:
> fix not yet in your tree

With the WARN_ON() in cancel_dirty_page() removed:

http://git2.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ecdfc9787fe527491baefc22dce8b2dbd5b2908d

XFS will behave exactly the same as 2.6.19 and previous releases.
The patches I sent were only ever really workarounds to greatly
reduce the race window that could lead to the warning being
triggered.

We really need Nick Piggin's invalidate/truncate/mmap race fixes to
properly solve the XFS issues uncovered by Linus' changes. Given
that we haven't had any reported cases of data corruption on XFS
(and I couldn't trigger any even when seeing the warnings) I think
we are fairly safe just maintaining the status quo and waiting the
right fix to make it's way into the tree....

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

  parent reply	other threads:[~2007-01-31 11:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-29 20:30 Chuck Ebbert
2007-01-29 20:35 ` Josh Boyer
2007-01-29 20:38   ` Chuck Ebbert
2007-02-07 20:36     ` Greg KH
2007-01-29 21:04 ` Mike Houston
2007-01-29 22:13   ` Bron Gondwana
2007-01-30 20:39     ` Adrian Bunk
2007-01-31  1:33       ` Mark Lord
2007-01-31  2:36         ` Linus Torvalds
2007-01-31  5:49           ` Bron Gondwana
2007-01-31  7:02           ` Adrian Bunk
2007-01-31 10:42             ` Reiserfs and MMAP (was: How many people are using 2.6.16?) Bron Gondwana
2007-01-31 11:49             ` David Chinner [this message]
2007-01-31 14:34               ` How many people are using 2.6.16? Steve French (smfltc)
2007-01-31 15:34             ` Linus Torvalds
2007-02-01 12:13             ` Vladimir V. Saveliev
2007-02-03  1:39               ` Adrian Bunk
2007-01-30 23:52   ` Adrian Bunk
2007-01-31  1:48     ` Mike Houston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070131114935.GP33919298@melbourne.sgi.com \
    --to=dgc@sgi.com \
    --cc=brong@fastmail.fm \
    --cc=bunk@stusta.de \
    --cc=cebbert@redhat.com \
    --cc=dsd@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@rtr.ca \
    --cc=mikeserv@bmts.com \
    --cc=reiserfs-dev@namesys.com \
    --cc=samba-technical@lists.samba.org \
    --cc=shaggy@linux.vnet.ibm.com \
    --cc=smfltc@us.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vs@namesys.com \
    --cc=xfs-masters@oss.sgi.com \
    --subject='Re: How many people are using 2.6.16?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).