From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030332AbXAaRWJ (ORCPT ); Wed, 31 Jan 2007 12:22:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030340AbXAaRWJ (ORCPT ); Wed, 31 Jan 2007 12:22:09 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:58877 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030332AbXAaRWG (ORCPT ); Wed, 31 Jan 2007 12:22:06 -0500 Date: Wed, 31 Jan 2007 18:19:57 +0100 From: Ingo Molnar To: Daniel Walker Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, johnstul@us.ibm.com, Thomas Gleixner Subject: Re: [PATCH 08/23] clocksource: drop duplicate register checking Message-ID: <20070131171957.GE4468@elte.hu> References: <20070131033710.420168478@mvista.com> <20070131033805.498958666@mvista.com> <20070131095935.GA22377@elte.hu> <1170256393.9781.23.camel@imap.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1170256393.9781.23.camel@imap.mvista.com> User-Agent: Mutt/1.4.2.2i X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -4.3 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-4.3 required=5.9 tests=ALL_TRUSTED,BAYES_00 autolearn=no SpamAssassin version=3.0.3 -3.3 ALL_TRUSTED Did not pass through any untrusted hosts -1.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Daniel Walker wrote: > > if (is_registered_source(c)) { > > printk("register_clocksource: Cannot register %s. " > > "Already registered!", c->name); > > ret = -EBUSY; > > > > and Thomas' change keeps that property, but doesnt printk. Your > > change makes double registry possible, potentially crashing the > > kernel later on! (And this isnt theoretical, double registry did > > happen in practice when i debugged suspend problems on my SMP > > laptop.) > > My original patch set makes the duplicate register checking better > (which I dropped) .. I'll be happy to reintroduce that part of it.. why if Thomas' patch: simplify-the-registration-of-clocksources.patch already does it? Ingo