LKML Archive on
help / color / mirror / Atom feed
From: Alan <>
To: Jeff Garzik <>
Subject: Re: [PATCH] libata: Fix (hopefully) all the remaining problems with devices failing setup/identify
Date: Wed, 31 Jan 2007 17:47:24 +0000	[thread overview]
Message-ID: <20070131174724.7b17153a@localhost.localdomain> (raw)
In-Reply-To: <>

> Looks like you should use ata_busy_wait() here, rather than reproducing 
> the same code again.

It waits in 10uS chunks while 1uS chunks were used in the workaround.
Could indeed do that once I know the fix is right. While I'm at it the
ata_busy_wait kerneldoc is borked so here's a fix

Signed-off-by: Alan Cox <>

--- linux.vanilla-2.6.20-rc6-mm3/include/linux/libata.h	2007-01-31 14:20:43.000000000 +0000
+++ linux-2.6.20-rc6-mm3/include/linux/libata.h	2007-01-31 17:19:04.703229512 +0000
@@ -1052,6 +1053,8 @@
  *	ata_busy_wait - Wait for a port status register
  *	@ap: Port to wait for.
+ *	@bits: bits that must be clear
+ *	@max: number of 10uS waits to perform
  *	Waits up to max*10 microseconds for the selected bits in the port's
  *	status register to be cleared.

  reply	other threads:[~2007-01-31 17:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-31 17:26 Alan
2007-01-31 17:22 ` Jeff Garzik
2007-01-31 17:47   ` Alan [this message]
2007-02-02 16:54     ` Jeff Garzik
2007-02-02 18:23 ` Andrey Borzenkov
2007-02-06 13:42 ` Haavard Skinnemoen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070131174724.7b17153a@localhost.localdomain \ \ \ \ \
    --subject='Re: [PATCH] libata: Fix (hopefully) all the remaining problems with devices failing setup/identify' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).