LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Duncan Sands <duncan.sands@math.u-psud.fr>
Cc: linux-kernel@vger.kernel.org
Subject: Re: remove_proc_entry and read_proc
Date: Wed, 31 Jan 2007 21:42:51 +0300	[thread overview]
Message-ID: <20070131184251.GA5544@martell.zuzino.mipt.ru> (raw)
In-Reply-To: <200701311154.35929.duncan.sands@math.u-psud.fr>

On Wed, Jan 31, 2007 at 11:54:35AM +0100, Duncan Sands wrote:
> Can read_proc still be executing when remove_proc_entry returns?
>
> In my driver [*] I allocate some data and create a proc entry using
> create_proc_entry.  My read method reads from my allocated data.  When
> shutting down, I call remove_proc_entry and immediately free the data.
> If some call to read_proc is still executing at this point then it will
> be accessing freed memory.  Can this happen?  I've been rummaging around
> in fs/proc to see what prevents it, but didn't find anything yet.

This should be fixed by the following patch (in -mm currently):
http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20-rc6/2.6.20-rc6-mm3/broken-out/fix-rmmod-read-write-races-in-proc-entries.patch

Tell me if you're unsure it will.


  reply	other threads:[~2007-01-31 18:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-31 10:54 Duncan Sands
2007-01-31 18:42 ` Alexey Dobriyan [this message]
2007-01-31 19:26   ` Duncan Sands
2007-02-01 10:15     ` Duncan Sands
2007-02-01 16:09 Alexey Dobriyan
2007-02-02  7:31 ` Duncan Sands
2007-02-05 11:39   ` Alexey Dobriyan
2007-02-05 12:05     ` Duncan Sands

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070131184251.GA5544@martell.zuzino.mipt.ru \
    --to=adobriyan@gmail.com \
    --cc=duncan.sands@math.u-psud.fr \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: remove_proc_entry and read_proc' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).