LKML Archive on
help / color / mirror / Atom feed
From: "Sébastien Dugué" <>
To: linux-kernel <>
Cc: Andrew Morton <>, linux-aio <>,
	Bharata B Rao <>,
	Christoph Hellwig <>,
	Suparna Bhattacharya <>,
	Ulrich Drepper <>,
	Zach Brown <>,
	Oleg Nesterov <>,
	Badari Pulavarty <>,
	Benjamin LaHaise <>,
	Jean Pierre Dion <>
Subject: [PATCH -mm 0/7][AIO] - AIO completion signal notification v6
Date: Thu, 1 Feb 2007 10:22:52 +0100	[thread overview]
Message-ID: <20070201102252.240130c6@frecb000686> (raw)

  Hi Andrew,

  here is the latest rework of the aio notification and listio support
patches with comments from Oleg Nesterov and you addressed.


  This set now consists in 7 patches:

	1. rework-compat-sys-io-submit: cleanup the sys_io_submit() compat layer,
	   making it more efficient and laying out the base for the following patches

	2. aio-header-fix-includes: fixes the double inclusion of uio.h in aio.h

	3. aio-fix-access_ok-check: fixes the access_ok() checks

	4. make-good_sigevent-non-static: move good_sigevent into signal.c, rename
	   it to something more meaningfull and make it non-static

	5. make-__sigqueue_alloc-free-non-static: make __sigqueue_alloc() and
	   __sigqueue_free() non static

	6. aio-notify-sig: the AIO completion signal notification

	7. add-listio-syscall-support: adds listio support via a new syscall

  Description are in the individual patches.

  Changes from v5: based on comments from Oleg Nesterov and Andrew Morton

	- Fix for signo range not checked in the SIGEV_THREAD_ID case in
	- renamed good_sigevent() to sigevent_find_task()

	- Fixed the access_ok checks in sys_io_submit() and

	- Made __sigqueue_alloc() and __sigqueue_free() non static
	- Reworked the aio code to directly use __sigqueue_alloc() and
	  __sigqueue_free() and avoid messing with SIGQUEUE_PREALLOC

	- Removed the unneeded PF_EXITING check in aio_setup_sigevent()
	- Added a comment in aio_setup_sigevent() for why there is no task
	  ref leak
	- Changed read_lock(&tasklist_lock) to rcu_read_lock() in

	- Fixed an ioctx reference leak in compat_sys_lio_submit()
	- Renamed lio_check() as lio_notify()
	- Added comments to lio_notify() and lio_create()
	- Replaced sigqueue_free() by __sigqueue_free() in lio_notify()

  Changes from v4:
	No comments received for v4, so it must be perfect ;-)
	replaced the IOCB_CMD_GROUP listio implementation with Bharata's
	syscall approach which I find much cleaner.

  Changes from v3:

	- added justification for the compat_sys_io_submit() cleanup - Zach Brown
	- more cleanups in compat_sys_io_submit() to put it in line with
	  sys_io_submit() - Zach Brown

	- Changed "Export good_sigevent()" patch name to "Make good_sigevent()
	  non-static" to better describe what it does. - Christoph Hellwig
	- Reworked good_sigevent() to make it more readable. - Christoph Hellwig

	- Simplified the use of the SIGEV_* constants in signal notification -
	  Christoph Hellwig
	- Take a reference on the target task both for the SIGEV_THREAD_ID and
	  SIGEV_SIGNAL cases.

  Changes from v2:
	- rebased to 2.6.19-rc6-mm2
	- reworked the sys_io_submit() compat layer as suggested by Zach Brown
	- fixed saving of a pointer to a task struct in aio-notify-sig as
	  pointed out by Andrew Morton

  Changes from v1:
	- cleanups suggested by Christoph Hellwig, Badari Pulavarty and
	Zach Brown
	- added lisio patch

             reply	other threads:[~2007-02-01  9:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-01  9:22 Sébastien Dugué [this message]
2007-02-01  9:26 ` [PATCH -mm 1/7][AIO] - Rework compat_sys_io_submit Sébastien Dugué
2007-02-01  9:29 ` [PATCH -mm 2/7][AIO] - fix aio.h includes Sébastien Dugué
2007-02-01  9:30 ` [PATCH -mm 3/7][AIO] - Fix access_ok() checks Sébastien Dugué
2007-02-01  9:30 ` [PATCH -mm 4/7][AIO] - Make good_sigevent() non-static Sébastien Dugué
2007-02-02 18:00   ` Oleg Nesterov
2007-02-05 11:09     ` Sébastien Dugué
2007-02-05 12:18     ` [PATCH -mm 4/7][AIO] Resend " Sébastien Dugué
2007-02-05 13:43       ` Oleg Nesterov
2007-02-05 16:00         ` [PATCH -mm][AIO] Fix AIO completion signal notification possible ref leak Sébastien Dugué
2007-02-05 17:13           ` Oleg Nesterov
2007-02-06  8:31             ` Sébastien Dugué
2007-02-06  9:22             ` [PATCH -mm][AIO] AIO completion signal notification fixes and cleanups Sébastien Dugué
2007-02-06 11:05               ` Oleg Nesterov
2007-02-06 11:39                 ` Sébastien Dugué
2007-02-06 11:57                 ` [PATCH -mm][AIO] AIO completion signal notification small cleanup Sébastien Dugué
2007-02-01  9:31 ` [PATCH -mm 5/7][AIO] - Make __sigqueue_free() and __sigqueue_alloc() non static Sébastien Dugué
2007-02-01  9:31 ` [PATCH -mm 6/7][AIO] - AIO completion signal notification Sébastien Dugué
2007-02-01  9:32 ` [PATCH -mm 7/7][AIO] - Add listio syscall support Sébastien Dugué

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070201102252.240130c6@frecb000686 \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH -mm 0/7][AIO] - AIO completion signal notification v6' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).