LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Sébastien Dugué" <sebastien.dugue@bull.net>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>, linux-aio <linux-aio@kvack.org>,
	Bharata B Rao <bharata@in.ibm.com>,
	Christoph Hellwig <hch@infradead.org>,
	Suparna Bhattacharya <suparna@in.ibm.com>,
	Ulrich Drepper <drepper@redhat.com>,
	Zach Brown <zach.brown@oracle.com>,
	Oleg Nesterov <oleg@tv-sign.ru>,
	Badari Pulavarty <pbadari@us.ibm.com>,
	Benjamin LaHaise <bcrl@linux.intel.com>,
	Jean Pierre Dion <jean-pierre.dion@bull.net>
Subject: [PATCH -mm 3/7][AIO] - Fix access_ok() checks
Date: Thu, 1 Feb 2007 10:30:11 +0100	[thread overview]
Message-ID: <20070201103011.69ebafc8@frecb000686> (raw)
In-Reply-To: <20070201102252.240130c6@frecb000686>


From: Sébastien Dugué <sebastien.dugue@bull.net>

                   Fix access_ok() checks in sys_io_submit() and 
                            compat_sys_io_submit()


  sys_io_submit() and compat_sys_io_submit() check for the number of
requests (nr) being positive, but the following access_ok() call uses
nr * sizeof(ptr) which can overlow to a negative number.

  Just make sure that nr * sizeof(ptr) is positive in the first place.


 aio.c    |    2 +-
 compat.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Signed-off-by: Sébastien Dugué <sebastien.dugue@bull.net>

Index: linux-2.6.20-rc6-mm3/fs/aio.c
===================================================================
--- linux-2.6.20-rc6-mm3.orig/fs/aio.c	2007-01-30 11:28:56.000000000 +0100
+++ linux-2.6.20-rc6-mm3/fs/aio.c	2007-01-30 11:32:42.000000000 +0100
@@ -1630,7 +1630,7 @@ asmlinkage long sys_io_submit(aio_contex
 	long ret = 0;
 	int i;
 
-	if (unlikely(nr < 0))
+	if (unlikely((nr*sizeof(*iocbpp)) < 0))
 		return -EINVAL;
 
 	if (unlikely(!access_ok(VERIFY_READ, iocbpp, (nr*sizeof(*iocbpp)))))
Index: linux-2.6.20-rc6-mm3/fs/compat.c
===================================================================
--- linux-2.6.20-rc6-mm3.orig/fs/compat.c	2007-01-30 11:30:29.000000000 +0100
+++ linux-2.6.20-rc6-mm3/fs/compat.c	2007-01-30 11:31:55.000000000 +0100
@@ -651,7 +651,7 @@ compat_sys_io_submit(aio_context_t ctx_i
 	long ret = 0;
 	int i;
 
-	if (unlikely(nr < 0))
+	if (unlikely((nr * sizeof(u32)) < 0))
 		return -EINVAL;
 
 	if (unlikely(!access_ok(VERIFY_READ, iocb, (nr * sizeof(u32)))))

  parent reply	other threads:[~2007-02-01  9:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-01  9:22 [PATCH -mm 0/7][AIO] - AIO completion signal notification v6 Sébastien Dugué
2007-02-01  9:26 ` [PATCH -mm 1/7][AIO] - Rework compat_sys_io_submit Sébastien Dugué
2007-02-01  9:29 ` [PATCH -mm 2/7][AIO] - fix aio.h includes Sébastien Dugué
2007-02-01  9:30 ` Sébastien Dugué [this message]
2007-02-01  9:30 ` [PATCH -mm 4/7][AIO] - Make good_sigevent() non-static Sébastien Dugué
2007-02-02 18:00   ` Oleg Nesterov
2007-02-05 11:09     ` Sébastien Dugué
2007-02-05 12:18     ` [PATCH -mm 4/7][AIO] Resend " Sébastien Dugué
2007-02-05 13:43       ` Oleg Nesterov
2007-02-05 16:00         ` [PATCH -mm][AIO] Fix AIO completion signal notification possible ref leak Sébastien Dugué
2007-02-05 17:13           ` Oleg Nesterov
2007-02-06  8:31             ` Sébastien Dugué
2007-02-06  9:22             ` [PATCH -mm][AIO] AIO completion signal notification fixes and cleanups Sébastien Dugué
2007-02-06 11:05               ` Oleg Nesterov
2007-02-06 11:39                 ` Sébastien Dugué
2007-02-06 11:57                 ` [PATCH -mm][AIO] AIO completion signal notification small cleanup Sébastien Dugué
2007-02-01  9:31 ` [PATCH -mm 5/7][AIO] - Make __sigqueue_free() and __sigqueue_alloc() non static Sébastien Dugué
2007-02-01  9:31 ` [PATCH -mm 6/7][AIO] - AIO completion signal notification Sébastien Dugué
2007-02-01  9:32 ` [PATCH -mm 7/7][AIO] - Add listio syscall support Sébastien Dugué

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070201103011.69ebafc8@frecb000686 \
    --to=sebastien.dugue@bull.net \
    --cc=akpm@osdl.org \
    --cc=bcrl@linux.intel.com \
    --cc=bharata@in.ibm.com \
    --cc=drepper@redhat.com \
    --cc=hch@infradead.org \
    --cc=jean-pierre.dion@bull.net \
    --cc=linux-aio@kvack.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=pbadari@us.ibm.com \
    --cc=suparna@in.ibm.com \
    --cc=zach.brown@oracle.com \
    --subject='Re: [PATCH -mm 3/7][AIO] - Fix access_ok() checks' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).