LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Sébastien Dugué" <sebastien.dugue@bull.net>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>, linux-aio <linux-aio@kvack.org>,
	Bharata B Rao <bharata@in.ibm.com>,
	Christoph Hellwig <hch@infradead.org>,
	Suparna Bhattacharya <suparna@in.ibm.com>,
	Ulrich Drepper <drepper@redhat.com>,
	Zach Brown <zach.brown@oracle.com>,
	Oleg Nesterov <oleg@tv-sign.ru>,
	Badari Pulavarty <pbadari@us.ibm.com>,
	Benjamin LaHaise <bcrl@linux.intel.com>,
	Jean Pierre Dion <jean-pierre.dion@bull.net>
Subject: [PATCH -mm 4/7][AIO] - Make good_sigevent() non-static
Date: Thu, 1 Feb 2007 10:30:53 +0100	[thread overview]
Message-ID: <20070201103053.64489048@frecb000686> (raw)
In-Reply-To: <20070201102252.240130c6@frecb000686>


From: Sébastien Dugué <sebastien.dugue@bull.net>

                Make good_sigevent() non-static and rename it


  Move good_sigevent() from posix-timers.c to signal.c where it belongs,
clean it up, rename it to sigevent_find_task() to better describe what the
function does and make it non-static so that it can be used by other
 subsystems.


 include/linux/signal.h |    1 +
 kernel/posix-timers.c  |   19 +------------------
 kernel/signal.c        |   24 ++++++++++++++++++++++++
 3 files changed, 26 insertions(+), 18 deletions(-)

Signed-off-by: Sébastien Dugué <sebastien.dugue@bull.net>


Index: linux-2.6.20-rc6-mm3/include/linux/signal.h
===================================================================
--- linux-2.6.20-rc6-mm3.orig/include/linux/signal.h	2007-01-30 11:41:27.000000000 +0100
+++ linux-2.6.20-rc6-mm3/include/linux/signal.h	2007-01-30 11:41:36.000000000 +0100
@@ -240,6 +240,7 @@ extern int sigprocmask(int, sigset_t *, 
 
 struct pt_regs;
 extern int get_signal_to_deliver(siginfo_t *info, struct k_sigaction *return_ka, struct pt_regs *regs, void *cookie);
+extern struct task_struct * sigevent_find_task(sigevent_t *);
 
 extern struct kmem_cache *sighand_cachep;
 
Index: linux-2.6.20-rc6-mm3/kernel/posix-timers.c
===================================================================
--- linux-2.6.20-rc6-mm3.orig/kernel/posix-timers.c	2007-01-30 11:41:27.000000000 +0100
+++ linux-2.6.20-rc6-mm3/kernel/posix-timers.c	2007-01-30 11:41:36.000000000 +0100
@@ -367,23 +367,6 @@ static enum hrtimer_restart posix_timer_
 	return ret;
 }
 
-static struct task_struct * good_sigevent(sigevent_t * event)
-{
-	struct task_struct *rtn = current->group_leader;
-
-	if ((event->sigev_notify & SIGEV_THREAD_ID ) &&
-		(!(rtn = find_task_by_pid(event->sigev_notify_thread_id)) ||
-		 rtn->tgid != current->tgid ||
-		 (event->sigev_notify & ~SIGEV_THREAD_ID) != SIGEV_SIGNAL))
-		return NULL;
-
-	if (((event->sigev_notify & ~SIGEV_THREAD_ID) != SIGEV_NONE) &&
-	    ((event->sigev_signo <= 0) || (event->sigev_signo > SIGRTMAX)))
-		return NULL;
-
-	return rtn;
-}
-
 void register_posix_clock(const clockid_t clock_id, struct k_clock *new_clock)
 {
 	if ((unsigned) clock_id >= MAX_CLOCKS) {
@@ -496,7 +479,7 @@ sys_timer_create(const clockid_t which_c
 		new_timer->it_sigev_value = event.sigev_value;
 
 		read_lock(&tasklist_lock);
-		if ((process = good_sigevent(&event))) {
+		if ((process = sigevent_find_task(&event))) {
 			/*
 			 * We may be setting up this process for another
 			 * thread.  It may be exiting.  To catch this
Index: linux-2.6.20-rc6-mm3/kernel/signal.c
===================================================================
--- linux-2.6.20-rc6-mm3.orig/kernel/signal.c	2007-01-30 11:41:27.000000000 +0100
+++ linux-2.6.20-rc6-mm3/kernel/signal.c	2007-01-30 11:41:36.000000000 +0100
@@ -1213,6 +1213,30 @@ int group_send_sig_info(int sig, struct 
 	return ret;
 }
 
+/***
+ * sigevent_find_task - check and get target task from a sigevent.
+ * @event: the sigevent to be checked
+ *
+ * This function must be called with the tasklist_lock held for reading.
+ */
+struct task_struct * sigevent_find_task(sigevent_t * event)
+{
+	struct task_struct *task = NULL;
+
+	if (event->sigev_signo <= 0 || event->sigev_signo > SIGRTMAX)
+		return NULL;
+
+	if ((event->sigev_notify & SIGEV_THREAD_ID ) == SIGEV_THREAD_ID) {
+		task = find_task_by_pid(event->sigev_notify_thread_id);
+
+		if (!task || task->tgid != current->tgid)
+			task = NULL;
+	} else if (event->sigev_notify == SIGEV_SIGNAL)
+		task = current->group_leader;
+
+	return task;
+}
+
 /*
  * kill_pgrp_info() sends a signal to a process group: this is what the tty
  * control characters do (^C, ^Z etc)

  parent reply	other threads:[~2007-02-01  9:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-01  9:22 [PATCH -mm 0/7][AIO] - AIO completion signal notification v6 Sébastien Dugué
2007-02-01  9:26 ` [PATCH -mm 1/7][AIO] - Rework compat_sys_io_submit Sébastien Dugué
2007-02-01  9:29 ` [PATCH -mm 2/7][AIO] - fix aio.h includes Sébastien Dugué
2007-02-01  9:30 ` [PATCH -mm 3/7][AIO] - Fix access_ok() checks Sébastien Dugué
2007-02-01  9:30 ` Sébastien Dugué [this message]
2007-02-02 18:00   ` [PATCH -mm 4/7][AIO] - Make good_sigevent() non-static Oleg Nesterov
2007-02-05 11:09     ` Sébastien Dugué
2007-02-05 12:18     ` [PATCH -mm 4/7][AIO] Resend " Sébastien Dugué
2007-02-05 13:43       ` Oleg Nesterov
2007-02-05 16:00         ` [PATCH -mm][AIO] Fix AIO completion signal notification possible ref leak Sébastien Dugué
2007-02-05 17:13           ` Oleg Nesterov
2007-02-06  8:31             ` Sébastien Dugué
2007-02-06  9:22             ` [PATCH -mm][AIO] AIO completion signal notification fixes and cleanups Sébastien Dugué
2007-02-06 11:05               ` Oleg Nesterov
2007-02-06 11:39                 ` Sébastien Dugué
2007-02-06 11:57                 ` [PATCH -mm][AIO] AIO completion signal notification small cleanup Sébastien Dugué
2007-02-01  9:31 ` [PATCH -mm 5/7][AIO] - Make __sigqueue_free() and __sigqueue_alloc() non static Sébastien Dugué
2007-02-01  9:31 ` [PATCH -mm 6/7][AIO] - AIO completion signal notification Sébastien Dugué
2007-02-01  9:32 ` [PATCH -mm 7/7][AIO] - Add listio syscall support Sébastien Dugué

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070201103053.64489048@frecb000686 \
    --to=sebastien.dugue@bull.net \
    --cc=akpm@osdl.org \
    --cc=bcrl@linux.intel.com \
    --cc=bharata@in.ibm.com \
    --cc=drepper@redhat.com \
    --cc=hch@infradead.org \
    --cc=jean-pierre.dion@bull.net \
    --cc=linux-aio@kvack.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=pbadari@us.ibm.com \
    --cc=suparna@in.ibm.com \
    --cc=zach.brown@oracle.com \
    --subject='Re: [PATCH -mm 4/7][AIO] - Make good_sigevent() non-static' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).