LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Luca Tettamanti <kronos.it@gmail.com>
Cc: Adrian Bunk <bunk@stusta.de>, Peter Osterlund <petero2@telia.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [2.6.20-rc6] pktcdvd doesn't work
Date: Thu, 1 Feb 2007 18:21:47 -0800	[thread overview]
Message-ID: <20070201182147.2835668e.akpm@osdl.org> (raw)
In-Reply-To: <20070201230752.GA17679@dreamland.darkstar.lan>

On Fri, 2 Feb 2007 00:07:52 +0100 Luca Tettamanti <kronos.it@gmail.com> wrote:

> Il Thu, Feb 01, 2007 at 12:30:44AM +0100, Adrian Bunk ha scritto: 
> > On Tue, Jan 30, 2007 at 08:53:19PM +0100, Luca Tettamanti wrote:
> > > Hi,
> > > pktcdvd on kernel 2.6.20-rc6 is not working as expected. Any file that
> > > is written to the device is lost after umount.
> > > I rarely use pktcdvd but at some point it used to work on my system.
> > > 
> > > This is what I'm doing:
> > > 
> > > root@dreamland:/tmp# cdrwtool -d /dev/scd0 -q
> > > using device /dev/scd0
> > > 1029KB internal buffer
> > > setting write speed to 12x
> > > Settings for /dev/scd0:
> > >         Fixed packets, size 32
> > >         Mode-2 disc
> > >...
> > 
> > Does 2.6.20-rc7 work?
> > If no, does it work after applying the attached patch?
> > If no, does 2.6.19.2 work?
> 
> Git current + the following patch works.
> 
> > diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
> > index 6246219..7c95c76 100644
> > --- a/drivers/block/pktcdvd.c
> > +++ b/drivers/block/pktcdvd.c
> > @@ -765,34 +765,47 @@ static inline struct bio *pkt_get_list_first(struct bio **list_head, struct bio
> >   */
> >  static int pkt_generic_packet(struct pktcdvd_device *pd, struct packet_command *cgc)
> >  {
> > -	request_queue_t *q = bdev_get_queue(pd->bdev);
> > +	char sense[SCSI_SENSE_BUFFERSIZE];

Where did this patch come from?

  reply	other threads:[~2007-02-02  2:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-30 19:53 Luca Tettamanti
2007-01-30 20:02 ` Jan Engelhardt
2007-01-30 20:36   ` Luca Tettamanti
2007-01-30 20:42     ` Jan Engelhardt
2007-01-30 23:16       ` Luca Tettamanti
2007-01-31 10:58         ` Jeff Garzik
2007-01-31 19:17           ` Fabio Comolli
2007-01-31 19:59           ` Luca
2007-01-31 23:10           ` Adrian Bunk
2007-01-31 23:38             ` Luca Tettamanti
2007-01-31 23:30 ` Adrian Bunk
2007-02-01 23:07   ` Luca Tettamanti
2007-02-02  2:21     ` Andrew Morton [this message]
2007-02-02  2:33       ` Adrian Bunk
2007-02-02  4:07         ` Andrew Morton
2007-02-02  5:32           ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070201182147.2835668e.akpm@osdl.org \
    --to=akpm@linux-foundation.org \
    --cc=bunk@stusta.de \
    --cc=kronos.it@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petero2@telia.com \
    --subject='Re: [2.6.20-rc6] pktcdvd doesn'\''t work' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).