LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Blacklist hsfmodem module
@ 2006-10-28  0:41 Alexey Dobriyan
  2006-11-01 11:21 ` Jan Engelhardt
  0 siblings, 1 reply; 37+ messages in thread
From: Alexey Dobriyan @ 2006-10-28  0:41 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel

Google CodeSeacrh for

	MODULE_LICENSE.*0

and you'll see

   hsfmodem-7.47.00.03x86_64full/modules/cnxthwusb_common.c - 6 identical

    15: MODULE_DESCRIPTION("Conexant low-level hardware driver");
        MODULE_LICENSE("GPL\0for files in the \"GPL\" directory; for others, only LICENSE file applies");
	MODULE_INFO(supported, "yes");
   gentoo.osuosl.org/.../hsfmodem-7.47.00.03x86_64full.tar.gz - Unknown License - C - More from hsfmodem-7.47.00.03x86_64full.tar.gz »

It seems, hcfpcimodem-1.10full.tar.gz from
http://www.linuxant.com/drivers/hcf/full/downloads.php
also uses GPL\0 trick.

Patch is obviously not tested (and I'm not sure name is right, got it from
Ubuntu forums and tarball filename),

Does someone know internal contact so we can weed out all names and
blacklist them in bulk?

P.S.: Curiously enough, binary parts are *.O , not *.o .
	Presumably, .o suffix scares their developers, while tainting
	messages are busy scaring their users.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 kernel/module.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1721,6 +1721,9 @@ #endif
 		add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
 	if (strcmp(mod->name, "driverloader") == 0)
 		add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
+	/* LinuxAnt is politely asked to stop GPL\0 idiocy. */
+	if (strcmp(mod->name, "hsfmodem") == 0)
+		add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
 
 	/* Set up MODINFO_ATTR fields */
 	setup_modinfo(mod, sechdrs, infoindex);


^ permalink raw reply	[flat|nested] 37+ messages in thread

end of thread, other threads:[~2007-02-12 22:38 UTC | newest]

Thread overview: 37+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-28  0:41 [PATCH] Blacklist hsfmodem module Alexey Dobriyan
2006-11-01 11:21 ` Jan Engelhardt
2007-02-01 21:20   ` [PATCH] Ban module license tag string termination trick Jan Engelhardt
2007-02-01 21:28     ` [m-i-t part] " Jan Engelhardt
2007-02-01 21:55     ` [PATCH] " Randy Dunlap
2007-02-01 22:17     ` Jon Masters
2007-02-01 22:30       ` Trent Waddington
2007-02-01 23:34         ` Auke Kok
2007-02-02  8:24           ` David Schwartz
2007-02-02 10:45             ` Helge Hafting
2007-02-03 18:31               ` David Schwartz
2007-02-03 20:47                 ` Jan Engelhardt
2007-02-03 22:21                   ` Alan
2007-02-03 23:32                     ` Jon Masters
2007-02-04  0:05                       ` Alan
2007-02-04  7:56                   ` David Schwartz
2007-02-07 12:18                 ` Helge Hafting
2007-02-07 18:56                   ` David Schwartz
2007-02-12 15:50                     ` Helge Hafting
2007-02-12 16:42                       ` Alan
2007-02-12 22:37                       ` David Schwartz
2007-02-02  0:17       ` Tomas Carnecky
2007-02-02  0:51         ` Trent Waddington
2007-02-02  2:19           ` Valdis.Kletnieks
2007-02-02  3:12           ` Arjan van de Ven
2007-02-02  6:15             ` Jon Masters
2007-02-02 14:53     ` Paul Rolland
2007-02-02 15:11       ` Jan Engelhardt
2007-02-02 16:53         ` Randy Dunlap
2007-02-02 17:41           ` Jan Engelhardt
2007-02-02 17:49             ` Randy Dunlap
2007-02-02 19:06               ` Jan Engelhardt
2007-02-03  1:12                 ` Randy Dunlap
2007-02-03  1:29                   ` Jan Engelhardt
2007-02-02 18:37         ` Paul Rolland
2007-02-02 19:08           ` Jan Engelhardt
2007-02-04  8:14             ` Paul Rolland

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).