LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [RFT] sky2 auto negotiation PHY errata
@ 2007-02-02 19:28 Stephen Hemminger
0 siblings, 0 replies; only message in thread
From: Stephen Hemminger @ 2007-02-02 19:28 UTC (permalink / raw)
To: netdev, linux-kernel
This patch does the Marvell errata before auto negotiation
(from drivers/phy/marvell.c). The Yukon II chips have an internal
version of the same PHY, so perhaps this errata is necessary for them
as well.
For test only, but it may fix some of the hangs. It seems to fix
the PHY lockups I saw yesterday on Mac Mini.
---
drivers/net/sky2.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index 822dd0b..4f04ffa 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -387,6 +387,14 @@ static void sky2_phy_init(struct sky2_hw
if (sky2->autoneg == AUTONEG_ENABLE) {
if (sky2_is_copper(hw)) {
+ /* Errata setup */
+ gm_phy_write(hw, port, PHY_MARV_PAGE_ADDR, 0x1f);
+ gm_phy_write(hw, port, PHY_MARV_PAGE_DATA, 0x200c);
+ gm_phy_write(hw, port, PHY_MARV_PAGE_ADDR, 5);
+ gm_phy_write(hw, port, PHY_MARV_PAGE_DATA, 0);
+ gm_phy_write(hw, port, PHY_MARV_PAGE_DATA, 0x100);
+
+
if (sky2->advertising & ADVERTISED_1000baseT_Full)
ct1000 |= PHY_M_1000C_AFD;
if (sky2->advertising & ADVERTISED_1000baseT_Half)
--
1.4.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-02-02 19:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-02 19:28 [RFT] sky2 auto negotiation PHY errata Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).