LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Vasquez <andrew.vasquez@qlogic.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-SCSI Mailing List <linux-scsi@vger.kernel.org>,
Nigel Kirkland <nigel.kirkland@qlogic.com>
Subject: Re: [BUG] Unable to handle kernel NULL pointer dereference...as_move_to_dispatch+0x11/0x135
Date: Fri, 2 Feb 2007 12:56:30 -0800 [thread overview]
Message-ID: <20070202205630.GI3737@andrew-vasquezs-computer.local> (raw)
In-Reply-To: <20070201232302.905962b6.akpm@linux-foundation.org>
On Thu, 01 Feb 2007, Andrew Morton wrote:
> On Mon, 22 Jan 2007 10:35:10 -0800 Andrew Vasquez <andrew.vasquez@qlogic.com> wrote:
> > Basically what is happening from the FC side is the initiator executes
> > a simple dt test:
> >
> > dt of=/dev/raw/raw1 procs=8 oncerr=abort bs=16k disable=stats limit=2m passes=1000000 pattern=iot dlimit=2048
> >
> > against a single lun (a very basic Windows target mode driver).
> > During the test a port-enable, port-disable script is running agains
> > the switch's port that is connected to the target (this occurs every
> > sixty seconds (for a disabled duration of 2 seconds). Additionally,
> > the target itself is set to LOGO (logout) or drop off the topology
> > every 30 seconds.
>
> I don't understand what effect the port-enable/port-disable has upon the
> system. Will it cause I/O errors, or what?
No I/O errors should make there way to the upper-layers (block/FS).
The system *should* be shielded from the fibre-channel fabric events.
I just wanted to explain what the (basic sanity) test did.
> > This test runs fine up to 2.6.19.
>
> One thing we did in there was to give direct-io-against-blockdevs some
> special-case bio-preparation code. Perhaps this is tickling a bug somehow.
>
> We can revert that change like this:
>
>
> diff -puN fs/block_dev.c~a fs/block_dev.c
> --- a/fs/block_dev.c~a
> +++ a/fs/block_dev.c
> @@ -196,8 +196,47 @@ static void blk_unget_page(struct page *
> pvec->page[--pvec->idx] = page;
> }
>
> +static int
> +blkdev_get_blocks(struct inode *inode, sector_t iblock,
> + struct buffer_head *bh, int create)
...
Hmm, with this patch we've noted two main differences:
1) I/O throughput with the basic 'dd' command used (above) is back to
60MB/s, rather than the appalling 20-22 MB/s we were seeing with
2.6.20-rcX.
2) No panics -- so far with 2+ hours of testing. With our vanilla
system of 2.6.20-rc7, the test could trigger the panic within 15 to
20 minutes.
We'll let this run over the weekend -- I'll certainly let you know if
anything has changed (failures).
--
Andrew Vasquez
next prev parent reply other threads:[~2007-02-02 20:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-22 18:35 Andrew Vasquez
2007-02-02 7:23 ` Andrew Morton
2007-02-02 20:56 ` Andrew Vasquez [this message]
2007-02-02 22:12 ` Andrew Morton
2007-02-03 0:25 ` Andrew Morton
2007-02-03 1:18 ` Randy Dunlap
2007-02-03 4:30 ` Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070202205630.GI3737@andrew-vasquezs-computer.local \
--to=andrew.vasquez@qlogic.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nigel.kirkland@qlogic.com \
--subject='Re: [BUG] Unable to handle kernel NULL pointer dereference...as_move_to_dispatch+0x11/0x135' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).