LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/1] -  Altix: more ACPI PRT support
@ 2007-02-02 20:54 John Keller
  2007-02-03  1:37 ` Andrew Morton
  0 siblings, 1 reply; 3+ messages in thread
From: John Keller @ 2007-02-02 20:54 UTC (permalink / raw)
  To: linux-acpi; +Cc: ayoung, linux-ia64, linux-kernel, John Keller

The SN Altix platform does not conform to the 
IOSAPIC IRQ routing model. Add code in acpi_unregister_gsi()
to check if (acpi_irq_model == ACPI_IRQ_MODEL_PLATFORM) and
return.

Signed-off-by: John Keller <jpk@sgi.com>
---

Due to an oversight, this code was not added previously when
similar code was added to acpi_register_gsi().

http://marc.theaimsgroup.com/?l=linux-acpi&m=116680983430121&w=2

 arch/ia64/kernel/acpi.c |    3 +++
 1 file changed, 3 insertions(+)


Index: linux-2.6/arch/ia64/kernel/acpi.c
===================================================================
--- linux-2.6.orig/arch/ia64/kernel/acpi.c	2007-02-02 14:44:31.000000000 -0600
+++ linux-2.6/arch/ia64/kernel/acpi.c	2007-02-02 14:47:44.658143727 -0600
@@ -609,6 +609,9 @@ EXPORT_SYMBOL(acpi_register_gsi);
 
 void acpi_unregister_gsi(u32 gsi)
 {
+	if (acpi_irq_model == ACPI_IRQ_MODEL_PLATFORM)
+		return;
+
 	iosapic_unregister_intr(gsi);
 }
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] -  Altix: more ACPI PRT support
  2007-02-02 20:54 [PATCH 1/1] - Altix: more ACPI PRT support John Keller
@ 2007-02-03  1:37 ` Andrew Morton
  2007-02-03  2:56   ` Len Brown
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2007-02-03  1:37 UTC (permalink / raw)
  To: John Keller
  Cc: linux-acpi, ayoung, linux-ia64, linux-kernel, Len Brown, Luck, Tony

On Fri, 02 Feb 2007 14:54:12 -0600
John Keller <jpk@sgi.com> wrote:

> The SN Altix platform does not conform to the 
> IOSAPIC IRQ routing model. Add code in acpi_unregister_gsi()
> to check if (acpi_irq_model == ACPI_IRQ_MODEL_PLATFORM) and
> return.
> 
> Signed-off-by: John Keller <jpk@sgi.com>
> ---
> 
> Due to an oversight, this code was not added previously when
> similar code was added to acpi_register_gsi().
> 
> http://marc.theaimsgroup.com/?l=linux-acpi&m=116680983430121&w=2
> 
>  arch/ia64/kernel/acpi.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> 
> Index: linux-2.6/arch/ia64/kernel/acpi.c
> ===================================================================
> --- linux-2.6.orig/arch/ia64/kernel/acpi.c	2007-02-02 14:44:31.000000000 -0600
> +++ linux-2.6/arch/ia64/kernel/acpi.c	2007-02-02 14:47:44.658143727 -0600
> @@ -609,6 +609,9 @@ EXPORT_SYMBOL(acpi_register_gsi);
>  
>  void acpi_unregister_gsi(u32 gsi)
>  {
> +	if (acpi_irq_model == ACPI_IRQ_MODEL_PLATFORM)
> +		return;
> +
>  	iosapic_unregister_intr(gsi);
>  }

Given that the December 22 patch appears to be in mainline, and that this
patch is simple, I shall cheerily bypass maintainers and send it in for
2.6.20.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] -  Altix: more ACPI PRT support
  2007-02-03  1:37 ` Andrew Morton
@ 2007-02-03  2:56   ` Len Brown
  0 siblings, 0 replies; 3+ messages in thread
From: Len Brown @ 2007-02-03  2:56 UTC (permalink / raw)
  To: Andrew Morton
  Cc: John Keller, linux-acpi, ayoung, linux-ia64, linux-kernel, Luck, Tony

On Friday 02 February 2007 20:37, Andrew Morton wrote:
> On Fri, 02 Feb 2007 14:54:12 -0600
> John Keller <jpk@sgi.com> wrote:
> 
> > The SN Altix platform does not conform to the 
> > IOSAPIC IRQ routing model. Add code in acpi_unregister_gsi()
> > to check if (acpi_irq_model == ACPI_IRQ_MODEL_PLATFORM) and
> > return.
> > 
> > Signed-off-by: John Keller <jpk@sgi.com>
> > ---
> > 
> > Due to an oversight, this code was not added previously when
> > similar code was added to acpi_register_gsi().
> > 
> > http://marc.theaimsgroup.com/?l=linux-acpi&m=116680983430121&w=2
> > 
> >  arch/ia64/kernel/acpi.c |    3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > 
> > Index: linux-2.6/arch/ia64/kernel/acpi.c
> > ===================================================================
> > --- linux-2.6.orig/arch/ia64/kernel/acpi.c	2007-02-02 14:44:31.000000000 -0600
> > +++ linux-2.6/arch/ia64/kernel/acpi.c	2007-02-02 14:47:44.658143727 -0600
> > @@ -609,6 +609,9 @@ EXPORT_SYMBOL(acpi_register_gsi);
> >  
> >  void acpi_unregister_gsi(u32 gsi)
> >  {
> > +	if (acpi_irq_model == ACPI_IRQ_MODEL_PLATFORM)
> > +		return;
> > +
> >  	iosapic_unregister_intr(gsi);
> >  }
> 
> Given that the December 22 patch appears to be in mainline, and that this
> patch is simple, I shall cheerily bypass maintainers and send it in for
> 2.6.20.

Yep.

Acked-by: Len Brown <len.brown@intel.com>

thanks,
-Len


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-02-03  2:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-02 20:54 [PATCH 1/1] - Altix: more ACPI PRT support John Keller
2007-02-03  1:37 ` Andrew Morton
2007-02-03  2:56   ` Len Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).