LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: "Kawai, Hidehiro" <hidehiro.kawai.ez@hitachi.com>
Cc: Robin Holt <holt@sgi.com>,
	akpm@osdl.org, linux-kernel@vger.kernel.org, dhowells@redhat.com,
	alan@lxorguk.ukuu.org.uk, sugita <yumiko.sugita.yf@hitachi.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Satoshi OSHIMA <soshima@redhat.com>,
	"Hideo AOKI@redhat" <haoki@redhat.com>
Subject: Re: [PATCH 0/4] coredump: core dump masking support v2
Date: Sat, 3 Feb 2007 13:48:53 +0100	[thread overview]
Message-ID: <20070203124853.GA4191@elf.ucw.cz> (raw)
In-Reply-To: <45C08E33.9030300@hitachi.com>

Hi!

> >>>Can you make this a little more transparent?  Having a magic bitmask does
> >>>not seem like the best way to do stuff.  Could you maybe make a core_flags
> >>>directory with a seperate file for each flag.  It could still map to a
> >>>single field in the mm, but be broken out for the proc filesystem.
> >>
> >>It seems to be one of the good enhancement idea, thanks.:-)
> >>But currently, there is only one flag. So we had better keep this simple
> >>implementation until someone requests to add a new flag.
> > 
> > If that is the case, can we rename the file from core_flags to something
> > more descriptive like dump_core_skip_anonymous_mappings.  The name
> > is a wild suggestion, the renaming does seem fairly important to me.
> > Remember once you get this in, changing the name will be fairly difficult
> > as admin tools and documentation will adopt the name.  These are usually
> > cases where it is better to do it right the first time.
> 
> Okay, I'll adopt your idea in the next version.
> I'm going to provide the proc entry as follows:
> 
>   (1) /proc/<pid>/core_flags/flags
>   (2) /proc/<pid>/core_flags/omit_anon_shared
> 
> (1) is the same as current core_flags. It is for expert users.
> (2) corresponds to one bit in (1).
> If (2) is set to 1, anonymous shared memory of the process is never
> dumped.

Now, that's what I call an ugly interface.

Can we simply add ulimit with boolean value, that says dump
anon_shared... or not? It will be simpler and faster, because you'll
not need locking.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2007-02-03 13:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-26 14:05 Kawai, Hidehiro
2007-01-26 14:12 ` [PATCH 1/4] coredump: add an interface to specify omitted memory segment types Kawai, Hidehiro
2007-01-26 14:13 ` [PATCH 2/4] coredump: enable to omit anonymous shared memory Kawai, Hidehiro
2007-01-26 14:14 ` [PATCH 3/4] coredump: add a sysctl parameter to disable the core dump omitting feature Kawai, Hidehiro
2007-01-26 16:56   ` Pavel Machek
2007-01-26 14:15 ` [PATCH 4/4] coredump: documentation for proc and sysctl Kawai, Hidehiro
2007-01-26 15:29 ` [PATCH 0/4] coredump: core dump masking support v2 Robin Holt
2007-01-30  7:36   ` Kawai, Hidehiro
2007-01-30 12:44     ` Robin Holt
2007-01-31 12:40       ` Kawai, Hidehiro
2007-02-03 12:48         ` Pavel Machek [this message]
2007-02-14 13:26           ` Kawai, Hidehiro
2007-02-14 13:30             ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070203124853.GA4191@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dhowells@redhat.com \
    --cc=haoki@redhat.com \
    --cc=hidehiro.kawai.ez@hitachi.com \
    --cc=holt@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=soshima@redhat.com \
    --cc=yumiko.sugita.yf@hitachi.com \
    --subject='Re: [PATCH 0/4] coredump: core dump masking support v2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).