LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Ahmed S. Darwish" <darwish.07@gmail.com>
To: gerg@uclinux.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2.6.20] arch M68KNOMMU: user ARRAY_SIZE macro when appropriate
Date: Mon, 5 Feb 2007 04:41:51 +0200	[thread overview]
Message-ID: <20070205024151.GJ18118@Ahmed> (raw)
In-Reply-To: <20070205023935.GG18118@Ahmed>

Hi all,

A patch to use ARRAY_SIZE macro already defined in linux/kernel.h

Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
---
Patch isn't compile checked cause I have no M68KNOMMU board at hand.
Thanks,

diff --git a/arch/m68knommu/kernel/ptrace.c b/arch/m68knommu/kernel/ptrace.c
index 9130119..72d3496 100644
--- a/arch/m68knommu/kernel/ptrace.c
+++ b/arch/m68knommu/kernel/ptrace.c
@@ -62,7 +62,7 @@ static inline long get_reg(struct task_struct *task, int regno)
 
 	if (regno == PT_USP)
 		addr = &task->thread.usp;
-	else if (regno < sizeof(regoff)/sizeof(regoff[0]))
+	else if (regno < ARRAY_SIZE(regoff))
 		addr = (unsigned long *)(task->thread.esp0 + regoff[regno]);
 	else
 		return 0;
@@ -79,7 +79,7 @@ static inline int put_reg(struct task_struct *task, int regno,
 
 	if (regno == PT_USP)
 		addr = &task->thread.usp;
-	else if (regno < sizeof(regoff)/sizeof(regoff[0]))
+	else if (regno < ARRAY_SIZE(regoff))
 		addr = (unsigned long *) (task->thread.esp0 + regoff[regno]);
 	else
 		return -1;
diff --git a/arch/m68knommu/kernel/traps.c b/arch/m68knommu/kernel/traps.c
index 9129b3a..bed5f47 100644
--- a/arch/m68knommu/kernel/traps.c
+++ b/arch/m68knommu/kernel/traps.c
@@ -158,7 +158,7 @@ void show_stack(struct task_struct *task, unsigned long *stack)
 void bad_super_trap(struct frame *fp)
 {
 	console_verbose();
-	if (fp->ptregs.vector < 4*sizeof(vec_names)/sizeof(vec_names[0]))
+	if (fp->ptregs.vector < 4 * ARRAY_SIZE(vec_names))
 		printk (KERN_WARNING "*** %s ***   FORMAT=%X\n",
 			vec_names[(fp->ptregs.vector) >> 2],
 			fp->ptregs.format);

-- 
Ahmed S. Darwish
http://darwish-07.blogspot.com

  parent reply	other threads:[~2007-02-05  2:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-05  2:39 [PATCH 00] A series of patches to use ARRAY_SIZE macro under arch/ Ahmed S. Darwish
2007-02-05  2:40 ` [PATCH 2.6.20] arch CRIS: user ARRAY_SIZE macro when appropriate Ahmed S. Darwish
2007-02-05  2:41 ` [PATCH 2.6.20] arch AVR32: Use " Ahmed S. Darwish
2007-02-05  8:19   ` Haavard Skinnemoen
2007-02-05  2:41 ` Ahmed S. Darwish [this message]
2007-02-05  5:40   ` [PATCH 2.6.20] arch M68KNOMMU: user " Greg Ungerer
2007-02-05  2:42 ` [PATCH 2.6.20] arch MIPS: " Ahmed S. Darwish
2007-02-05 18:28   ` Ralf Baechle
2007-02-05  2:42 ` [PATCH 2.6.20] arch V850: " Ahmed S. Darwish
2007-02-05  2:42 ` [PATCH 2.6.20] arch PowerPC: " Ahmed S. Darwish
2007-02-05  2:43 ` [PATCH 2.6.20] arch PPC: " Ahmed S. Darwish
2007-02-05  2:43 ` [PATCH 2.6.20] arch M68K: " Ahmed S. Darwish
2007-02-05 20:15   ` Geert Uytterhoeven
2007-02-05  2:43 ` [PATCH 2.6.20] arch ARM: Use " Ahmed S. Darwish
2007-02-05  9:24   ` Ian Molton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070205024151.GJ18118@Ahmed \
    --to=darwish.07@gmail.com \
    --cc=gerg@uclinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 2.6.20] arch M68KNOMMU: user ARRAY_SIZE macro when appropriate' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox