LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alan <alan@lxorguk.ukuu.org.uk>
To: "Wu, Bryan" <Bryan.Wu@analog.com>,
	linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH 2/3] Blackfin: serial driver for Blackfin architecture against Linux kernel 2.6.20
Date: Mon, 5 Feb 2007 10:46:19 +0000	[thread overview]
Message-ID: <20070205104619.72cfd914@localhost.localdomain> (raw)
In-Reply-To: <D3664A3D9376A94BB603EE19E4AA246D10D64760@nwd2exm4.ad.analog.com>

On Mon, 5 Feb 2007 02:33:47 -0500
"Wu, Bryan" <Bryan.Wu@analog.com> wrote:

> 
> Hi everyone,
> 
> This is the serial driver supports Blackfin processors. It is designed
> for the serial core framework.
> 
> Signed-off-by: Bryan Wu <bryan.wu@analog.com>

> +
> +#ifdef CONFIG_SERIAL_BFIN_PIO
> +static void local_put_char(struct bfin_serial_port *uart, char ch)
> +{
> +	unsigned short status;
> +	int flags = 0;
> +
> +	local_irq_save(flags);
> +
> +	do {
> +		status = UART_GET_LSR(uart);
> +	} while (!(status & THRE));
> +
> +	UART_PUT_CHAR(uart, ch);
> +
> +	local_irq_restore(flags);

Should this not be using the spinlock like the other stuff rather than
local_irq_* ??

> +}
> +
> +static void
> +bfin_serial_rx_chars(struct bfin_serial_port *uart)

(trivial) Formatting - function name on same line as type

 +	local_irq_save(flags);

Likewise - why this not locks ?


Other than the locking bits looks ok, although has rather a lot of ifdefs

  reply	other threads:[~2007-02-05 10:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-05  7:33 Wu, Bryan
2007-02-05 10:46 ` Alan [this message]
2007-02-06  2:54   ` Aubrey Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070205104619.72cfd914@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=Bryan.Wu@analog.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 2/3] Blackfin: serial driver for Blackfin architecture against Linux kernel 2.6.20' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).