From: "Ahmed S. Darwish" <darwish.07@gmail.com> To: ebs@ebshome.net Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linuxppc-embedded@ozlabs.org Subject: [PATCH 2.6.20] ibm_emac: Use ARRAY_SIZE macro when appropriate Date: Mon, 5 Feb 2007 18:59:16 +0200 Message-ID: <20070205165916.GK3896@Ahmed> (raw) In-Reply-To: <20070205165429.GD3896@Ahmed> Hi, A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com> --- Patch isn't compile-tested cause I don't have the needed hardware. diff --git a/drivers/net/ibm_emac/ibm_emac_debug.c b/drivers/net/ibm_emac/ibm_emac_debug.c index 92f970d..1f70906 100644 --- a/drivers/net/ibm_emac/ibm_emac_debug.c +++ b/drivers/net/ibm_emac/ibm_emac_debug.c @@ -132,7 +132,7 @@ void emac_dbg_register(int idx, struct ocp_enet_private *dev) { unsigned long flags; - if (idx >= sizeof(__emacs) / sizeof(__emacs[0])) { + if (idx >= ARRAY_SIZE(__emacs)) { printk(KERN_WARNING "invalid index %d when registering EMAC for debugging\n", idx); @@ -148,7 +148,7 @@ void mal_dbg_register(int idx, struct ibm_ocp_mal *mal) { unsigned long flags; - if (idx >= sizeof(__mals) / sizeof(__mals[0])) { + if (idx >= ARRAY_SIZE(__mals)) { printk(KERN_WARNING "invalid index %d when registering MAL for debugging\n", idx); @@ -167,11 +167,11 @@ void emac_dbg_dump_all(void) local_irq_save(flags); - for (i = 0; i < sizeof(__mals) / sizeof(__mals[0]); ++i) + for (i = 0; i < ARRAY_SIZE(__mals); ++i) if (__mals[i]) emac_mal_dump(__mals[i]); - for (i = 0; i < sizeof(__emacs) / sizeof(__emacs[0]); ++i) + for (i = 0; i < ARRAY_SIZE(__emacs); ++i) if (__emacs[i]) emac_mac_dump(i, __emacs[i]); -- Ahmed S. Darwish http://darwish-07.blogspot.com
next prev parent reply index Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-02-05 16:54 [PATCH 00] A series of patches to use ARRAY_SIZE in `net' drivers Ahmed S. Darwish 2007-02-05 16:55 ` [PATCH 2.6.20] e1000: Use ARRAY_SIZE macro when appropriate Ahmed S. Darwish 2007-02-06 17:16 ` Auke Kok 2007-02-05 16:56 ` [PATCH 2.6.20] ipw2100: " Ahmed S. Darwish 2007-02-05 16:56 ` [PATCH 01/02] misc-net-drivers: " Ahmed S. Darwish 2007-02-05 16:57 ` [PATCH 02/02] " Ahmed S. Darwish 2007-02-05 16:58 ` [PATCH 2.6.20] misc-wireless: " Ahmed S. Darwish 2007-02-05 16:58 ` [PATCH 2.6.20] hostap: " Ahmed S. Darwish 2007-02-05 16:59 ` Ahmed S. Darwish [this message] 2007-02-05 20:22 ` [PATCH 2.6.20] ibm_emac: " Alexey Dobriyan 2007-02-06 9:12 ` Ahmed S. Darwish 2007-02-05 16:59 ` [PATCH 2.6.20] ixgb: " Ahmed S. Darwish 2007-02-05 20:18 ` Alexey Dobriyan 2007-02-05 20:31 ` Auke Kok 2007-02-06 10:00 ` Ahmed S. Darwish 2007-02-06 16:48 ` Auke Kok 2007-02-05 17:00 ` [PATCH 2.6.20] wavelan: " Ahmed S. Darwish 2007-02-05 20:17 ` Alexey Dobriyan 2007-02-06 9:34 ` Ahmed S. Darwish
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070205165916.GK3896@Ahmed \ --to=darwish.07@gmail.com \ --cc=ebs@ebshome.net \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-embedded@ozlabs.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lkml.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lkml.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lkml.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lkml.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lkml.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lkml.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lkml.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lkml.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lkml.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lkml.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lkml.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git