LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH][2/5] floppy.c: Remove pointless register keywords
@ 2007-02-05 23:29 Jesper Juhl
  0 siblings, 0 replies; only message in thread
From: Jesper Juhl @ 2007-02-05 23:29 UTC (permalink / raw)
  To: linux-kernel
  Cc: Andi Kleen, Trent Waddington, Bartlomiej Zolnierkiewicz,
	Alan Cox, Linus Torvalds, Jesper Juhl


This patch removes the use of the 'register' keyword from floppy.c

Marking some variables 'register' may have made sense in the past (though I 
doubt it for these ones), but these days I very much suspect that we would 
rather grant gcc more freedom in how to handle the variables and I doubt 
very much that in this day and age optimizing access to variables via 
'register' makes any sense for a floppy driver.  Let's just get rid of it.


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

 floppy.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.20/drivers/block/floppy.c.patch1	2007-02-05 23:11:03.000000000 +0100
+++ linux-2.6.20/drivers/block/floppy.c	2007-02-05 23:11:31.000000000 +0100
@@ -791,7 +791,7 @@
 
 static int set_dor(int fdc, char mask, char data)
 {
-	register unsigned char drive, unit, newdor, olddor;
+	unsigned char drive, unit, newdor, olddor;
 
 	if (FDCS->address == -1)
 		return -1;
@@ -946,7 +946,7 @@
 static void floppy_off(unsigned int drive)
 {
 	unsigned long volatile delta;
-	register int fdc = FDC(drive);
+	int fdc = FDC(drive);
 
 	if (!(FDCS->dor & (0x10 << UNIT(drive))))
 		return;




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-02-05 23:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-05 23:29 [PATCH][2/5] floppy.c: Remove pointless register keywords Jesper Juhl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).