LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alan <alan@lxorguk.ukuu.org.uk>
To: Robert Hancock <hancockr@shaw.ca>, akpm@osdl.org
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	drzeus-wbsd@drzeus.cx, wbsd-devel@list.drzeus.cx
Subject: [PATCH] kernel: shut up the IRQ mismatch messages (Re: wbsd: IRQ handler type mismatch)
Date: Tue, 6 Feb 2007 11:30:23 +0000	[thread overview]
Message-ID: <20070206113023.3c845bb2@localhost.localdomain> (raw)
In-Reply-To: <45C7F32B.1060402@shaw.ca>

On Mon, 05 Feb 2007 21:16:59 -0600
Robert Hancock <hancockr@shaw.ca> wrote:

> I'm seeing this on bootup on my laptop with recent kernels (currently 
> 2.6.20-rc6-mm3):

The problem is various drivers legally validly and sensibly try to claim
IRQs but the kernel insists on vomiting forth a giant irrelevant
debugging spew when the types clash.

Edit kernel/irq/manage.c go down to mismatch: in setup_irq() and ifdef
out the if clause that checks for mismatches. It'll then just do the
right thing and work sanely.

For the current -mm kernel this will do the trick (and moves it into
shared irq debugging as in debug mode the info spew is useful). I've had
a variant of this in my private tree for some time as I got fed up on the
mess on boxes where old legacy IRQs get reused.

Signed-off-by: Alan Cox <alan@redhat.com>

--- linux.vanilla-2.6.20-rc6-mm3/kernel/irq/manage.c	2007-01-31 14:20:43.000000000 +0000
+++ linux-2.6.20-rc6-mm3/kernel/irq/manage.c	2007-02-06 11:01:00.796928504 +0000
@@ -372,12 +372,14 @@
 	return 0;
 
 mismatch:
+#ifdef CONFIG_DEBUG_SHIRQ
 	if (!(new->flags & IRQF_PROBE_SHARED)) {
 		printk(KERN_ERR "IRQ handler type mismatch for IRQ %d\n", irq);
 		if (old_name)
 			printk(KERN_ERR "current handler: %s\n", old_name);
 		dump_stack();
 	}
+#endif	
 	spin_unlock_irqrestore(&desc->lock, flags);
 	return -EBUSY;
 }

  parent reply	other threads:[~2007-02-06 11:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-06  3:16 wbsd: IRQ handler type mismatch Robert Hancock
2007-02-06  7:01 ` Pierre Ossman
2007-02-06 11:30 ` Alan [this message]
2007-02-06 19:29   ` [PATCH] kernel: shut up the IRQ mismatch messages (Re: wbsd: IRQ handler type mismatch) Andrew Morton
2007-02-06 19:46     ` Alan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070206113023.3c845bb2@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akpm@osdl.org \
    --cc=drzeus-wbsd@drzeus.cx \
    --cc=hancockr@shaw.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wbsd-devel@list.drzeus.cx \
    --subject='[PATCH] kernel: shut up the IRQ mismatch messages (Re: wbsd: IRQ handler type mismatch)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).