LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jay Cliburn <jacliburn@bellsouth.net>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>,
	Xiong Huang <xiong_huang@attansic.com>,
	Chris Snook <csnook@redhat.com>, Jay Cliburn <jcliburn@gmail.com>,
	jgarzik@pobox.com, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [RFC: -mm patch] drivers/net/atl1/: possible cleanups
Date: Tue, 6 Feb 2007 18:19:10 -0600	[thread overview]
Message-ID: <20070206181910.4d27046a@osprey.hogchain.net> (raw)
In-Reply-To: <20070206221229.GH27397@stusta.de>

On Tue, 6 Feb 2007 23:12:29 +0100
Adrian Bunk <bunk@stusta.de> wrote:

> On Mon, Jan 29, 2007 at 08:45:28PM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.20-rc6-mm2:
> >...
> >  git-netdev-all.patch
> >...
> >  git trees
> >...
> 
> 
> This patch contains the following possible cleanups:
> - move extern declarations to atl1.h
> - make needlessly global code static

Adrian,

The atl1 driver currently follows this development pathway:

developer -> netdev#atl1 -> netdev#ALL -> -mm

Your patch is just a little bit out ahead of us.  Some of your suggested
changes are already in the pipeline; we're just waiting for Jeff to
merge netdev#atl1 into netdev#ALL.  Should be soon.

> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> ---
> 
> BTW: Can we get a MAINTAINERS entry for this driver?

Already submitted to netdev#atl1.

http://lkml.org/lkml/2007/2/3/174

> 
>  drivers/net/atl1/atl1.h         |    6 ++++--
>  drivers/net/atl1/atl1_ethtool.c |    3 ---
>  drivers/net/atl1/atl1_hw.c      |    6 ++----
>  drivers/net/atl1/atl1_main.c    |    8 +++-----
>  drivers/net/atl1/atl1_param.c   |    4 +---
>  5 files changed, 10 insertions(+), 17 deletions(-)
> 
> --- linux-2.6.20-rc6-mm3/drivers/net/atl1/atl1.h.old
> 2007-02-06 07:55:58.000000000 +0100 +++
> linux-2.6.20-rc6-mm3/drivers/net/atl1/atl1.h	2007-02-06
> 08:19:50.000000000 +0100 @@ -34,8 +34,10 @@ s32 atl1_up(struct
> atl1_adapter *adapter); void atl1_down(struct atl1_adapter *adapter);
>  int atl1_reset(struct atl1_adapter *adapter);
> -s32 atl1_setup_ring_resources(struct atl1_adapter *adapter);
> -void atl1_free_ring_resources(struct atl1_adapter *adapter);
> +
> +extern char atl1_driver_name[];
> +extern char atl1_driver_version[];

netdev#atl1 already has this change.

The rest of these I'll bundle up and submit to netdev#atl1, too.  Will
that work for you?

> +extern const struct ethtool_ops atl1_ethtool_ops;
>  
>  struct atl1_adapter;
>  
> --- linux-2.6.20-rc6-mm3/drivers/net/atl1/atl1_hw.c.old
> 2007-02-06 07:52:20.000000000 +0100 +++
> linux-2.6.20-rc6-mm3/drivers/net/atl1/atl1_hw.c	2007-02-06
> 07:56:22.000000000 +0100 @@ -31,8 +31,6 @@ #include "atl1.h"
>  
>  
> -extern char atl1_driver_name[];
> -
>  /**
>   * Reset the transmit and receive units; mask and clear all
> interrupts.
>   * hw - Struct containing variables accessed by shared code
> @@ -209,7 +207,7 @@
>   * get_permanent_address
>   * return 0 if get valid mac address, 
>   **/
> -int atl1_get_permanent_address(struct atl1_hw *hw)
> +static int atl1_get_permanent_address(struct atl1_hw *hw)
>  {
>  	u32 addr[2];
>  	u32 i, control;
> @@ -602,7 +600,7 @@
>  	return ret_val;
>  }
>  
> -struct atl1_spi_flash_dev flash_table[] = {
> +static struct atl1_spi_flash_dev flash_table[] = {
>  /*	MFR_NAME  WRSR  READ  PRGM  WREN  WRDI  RDSR  RDID
> SECTOR_ERASE CHIP_ERASE */ {"Atmel", 0x00, 0x03, 0x02, 0x06, 0x04,
> 0x05, 0x15, 0x52,        0x62}, {"SST",   0x01, 0x03, 0x02, 0x06,
> 0x04, 0x05, 0x90, 0x20,        0x60}, ---
> linux-2.6.20-rc6-mm3/drivers/net/atl1/atl1_ethtool.c.old
> 2007-02-06 07:57:04.000000000 +0100 +++
> linux-2.6.20-rc6-mm3/drivers/net/atl1/atl1_ethtool.c
> 2007-02-06 07:57:10.000000000 +0100 @@ -31,9 +31,6 @@ #include
> "atl1.h" 
> -extern char atl1_driver_name[];
> -extern char atl1_driver_version[];
> -
>  struct atl1_stats {
>  	char stat_string[ETH_GSTRING_LEN];
>  	int sizeof_stat;
> --- linux-2.6.20-rc6-mm3/drivers/net/atl1/atl1_param.c.old
> 2007-02-06 07:57:18.000000000 +0100 +++
> linux-2.6.20-rc6-mm3/drivers/net/atl1/atl1_param.c	2007-02-06
> 08:16:39.000000000 +0100 @@ -26,8 +26,6 @@ #include
> <linux/moduleparam.h> #include "atl1.h"
>  
> -extern char atl1_driver_name[];
> -
>  /**
>   * This is the only thing that needs to be changed to adjust the
>   * maximum number of ports that the driver can manage.
> @@ -68,7 +66,7 @@
>  module_param_array_named(flash_vendor, flash_vendor, int,
> &num_flash_vendor, 0); MODULE_PARM_DESC(flash_vendor, "SPI flash
> vendor"); 
> -int enable_msi;
> +static int enable_msi;
>  module_param(enable_msi, int, 0444);
>  MODULE_PARM_DESC(enable_msi, "Enable PCI MSI");
>  
> --- linux-2.6.20-rc6-mm3/drivers/net/atl1/atl1_main.c.old
> 2007-02-06 07:58:37.000000000 +0100 +++
> linux-2.6.20-rc6-mm3/drivers/net/atl1/atl1_main.c	2007-02-06
> 08:15:51.000000000 +0100 @@ -95,8 +95,6 @@ MODULE_LICENSE("GPL");
>  MODULE_VERSION(DRIVER_VERSION);
>  
> -extern struct ethtool_ops atl1_ethtool_ops;
> -
>  /**
>   * atl1_pci_tbl - PCI Device ID Table
>   **/
> @@ -178,7 +176,7 @@
>   *
>   * Return 0 on success, negative on failure
>   **/
> -s32 atl1_setup_ring_resources(struct atl1_adapter * adapter)
> +static s32 atl1_setup_ring_resources(struct atl1_adapter * adapter)
>  {
>  	struct atl1_tpd_ring *tpd_ring = &adapter->tpd_ring;
>  	struct atl1_rfd_ring *rfd_ring = &adapter->rfd_ring;
> @@ -1221,7 +1219,7 @@
>   * atl1_irq_disable - Mask off interrupt generation on the NIC
>   * @adapter: board private structure
>   **/
> -void atl1_irq_disable(struct atl1_adapter *adapter)
> +static void atl1_irq_disable(struct atl1_adapter *adapter)
>  {
>  	atomic_inc(&adapter->irq_sem);
>  	iowrite32(0, adapter->hw.hw_addr + REG_IMR);
> @@ -1749,7 +1747,7 @@
>   *
>   * Free all transmit software resources
>   **/
> -void atl1_free_ring_resources(struct atl1_adapter *adapter)
> +static void atl1_free_ring_resources(struct atl1_adapter *adapter)
>  {
>  	struct pci_dev *pdev = adapter->pdev;
>  	struct atl1_tpd_ring *tpd_ring = &adapter->tpd_ring;
> 
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2007-02-07  0:19 UTC|newest]

Thread overview: 124+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-30  4:45 2.6.20-rc6-mm3 Andrew Morton
2007-01-30  4:50 ` 2.6.20-rc6-mm3 Jeff Garzik
2007-01-30  5:11   ` 2.6.20-rc6-mm3 Andrew Morton
2007-01-30  9:56     ` 2.6.20-rc6-mm3 Evgeniy Polyakov
2007-01-30  8:16 ` 2.6.20-rc6-mm3 Sunil Naidu
2007-01-30  8:32   ` 2.6.20-rc6-mm3 Andrew Morton
2007-01-30  9:06 ` 2.6.20-rc6-mm3 Olivier Galibert
2007-01-30  9:26   ` 2.6.20-rc6-mm3 Andrew Morton
2007-01-30 18:47     ` 2.6.20-rc6-mm3 Olivier Galibert
2007-01-31  7:57     ` 2.6.20-rc6-mm3 Len Brown
2007-02-01  4:25     ` 2.6.20-rc6-mm3 Len Brown
2007-01-30 22:18 ` 2.6.20-rc6-mm3 Maciej Rutecki
2007-01-30 22:27   ` 2.6.20-rc6-mm3 Andrew Morton
2007-01-31  0:55     ` 2.6.20-rc6-mm3 Karsten Wiese
2007-01-31 13:22       ` 2.6.20-rc6-mm3 Ingo Molnar
2007-01-31 14:25         ` 2.6.20-rc6-mm3 Karsten Wiese
2007-02-01  8:01           ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-01 10:44             ` 2.6.20-rc6-mm3 Karsten Wiese
2007-03-01 11:11               ` 2.6.20-rc6-mm3 Karsten Wiese
2007-02-03  0:37             ` 2.6.20-rc6-mm3 Pavel Machek
2007-02-01 13:03       ` [PATCH -mm] gtod persistent clock resume fix Thomas Gleixner
2007-01-31 11:54     ` 2.6.20-rc6-mm3 Maciej Rutecki
2007-02-01  4:10       ` 2.6.20-rc6-mm3 Len Brown
2007-02-01  4:17         ` 2.6.20-rc6-mm3 Andrew Morton
2007-01-31  1:16   ` 2.6.20-rc6-mm3 Tilman Schmidt
2007-01-31  1:25     ` 2.6.20-rc6-mm3 Andrew Morton
2007-01-31 11:38       ` 2.6.20-rc6-mm3 Tilman Schmidt
2007-01-31 12:29         ` 2.6.20-rc6-mm3 Alexey Starikovskiy
2007-01-31 16:02           ` 2.6.20-rc6-mm3 Maciej Rutecki
2007-01-31 18:28           ` 2.6.20-rc6-mm3 Tilman Schmidt
2007-01-31 21:52 ` 2.6.20-rc6-mm3 Mattia Dongili
2007-01-31 23:21   ` 2.6.20-rc6-mm3 Mattia Dongili
2007-02-01 19:04     ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-01 19:36     ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-01 20:01       ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-01 21:11         ` 2.6.20-rc6-mm3 Mattia Dongili
2007-02-01 22:33           ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-02 19:18             ` dynticks + iptables almost stops the boot process [was: Re: 2.6.20-rc6-mm3] Mattia Dongili
2007-02-02 20:27               ` Thomas Gleixner
2007-02-02 20:43                 ` Mattia Dongili
2007-02-06 16:48                   ` Ingo Molnar
2007-02-06 19:28                     ` Mattia Dongili
2007-02-06 23:12                       ` Tilman Schmidt
2007-02-06 23:17                         ` Thomas Gleixner
2007-02-07  1:01                           ` Andrew Morton
2007-02-07 19:33                             ` Ingo Molnar
2007-02-01 21:37         ` 2.6.20-rc6-mm3 Mattia Dongili
2007-02-01 20:24       ` 2.6.20-rc6-mm3 Mattia Dongili
2007-02-01  0:14 ` 2.6.20-rc6-mm3 Christoph Lameter
2007-02-01  0:24   ` 2.6.20-rc6-mm3 Andrew Morton
2007-02-01  0:27     ` 2.6.20-rc6-mm3 Christoph Lameter
2007-02-01  0:36       ` 2.6.20-rc6-mm3 Andrew Morton
2007-02-01  0:38         ` 2.6.20-rc6-mm3 Christoph Lameter
2007-02-01  6:20         ` 2.6.20-rc6-mm3 David Chinner
2007-02-01  7:12           ` 2.6.20-rc6-mm3 Andrew Morton
2007-02-01 19:01             ` 2.6.20-rc6-mm3 Christoph Lameter
2007-02-01 19:18               ` 2.6.20-rc6-mm3 Jens Axboe
2007-02-01 20:18                 ` 2.6.20-rc6-mm3 Christoph Lameter
2007-02-01 20:26                   ` 2.6.20-rc6-mm3 Jens Axboe
2007-02-01 23:02                     ` 2.6.20-rc6-mm3 Christoph Lameter
2007-02-05 12:02                       ` 2.6.20-rc6-mm3 Jens Axboe
2007-02-05 12:17                         ` 2.6.20-rc6-mm3 Jens Axboe
2007-02-05 12:56                           ` 2.6.20-rc6-mm3 Jens Axboe
2007-02-05 18:20                             ` 2.6.20-rc6-mm3 Christoph Lameter
2007-02-05 18:34                               ` 2.6.20-rc6-mm3 Jens Axboe
2007-02-02  4:08                 ` 2.6.20-rc6-mm3 David Chinner
2007-02-02  7:31                   ` 2.6.20-rc6-mm3 Jens Axboe
2007-02-01 18:24 ` 2.6.20-rc6-mm3 Cedric Le Goater
2007-02-01 19:37   ` 2.6.20-rc6-mm3 Starikovskiy, Alexey Y
2007-02-01 20:29     ` 2.6.20-rc6-mm3 Cedric Le Goater
2007-02-01 20:38       ` 2.6.20-rc6-mm3 Cedric Le Goater
2007-02-02 14:22         ` 2.6.20-rc6-mm3 Starikovskiy, Alexey Y
2007-02-02 14:47           ` 2.6.20-rc6-mm3 Cedric Le Goater
2007-02-02 14:50             ` 2.6.20-rc6-mm3 Starikovskiy, Alexey Y
2007-02-02 16:04               ` 2.6.20-rc6-mm3 Cedric Le Goater
2007-02-03  7:30                 ` 2.6.20-rc6-mm3 Cedric Le Goater
2007-02-03  7:57                   ` 2.6.20-rc6-mm3 Starikovskiy, Alexey Y
2007-02-02 17:39 ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 16:03 ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 18:36   ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-06 18:45     ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 19:07       ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-06 19:55         ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 20:20           ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-06 20:40             ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 20:52               ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-06 20:56                 ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 21:09                   ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-06 21:20                     ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-06 21:23                     ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 21:41                       ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-06 21:54                         ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 22:08                           ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-06 22:42                             ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 22:56                               ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-06 23:04                                 ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 23:14                                   ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-06 23:22                                     ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 23:28                                       ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-06 23:35                                         ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 23:44                                           ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-06 23:51                                           ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-07  2:46                                             ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 23:36                                       ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-07  1:12                                         ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-07 14:53                                           ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-06 23:37                                       ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-06 22:13                           ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-06 21:43                       ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-06 21:59                         ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 21:17               ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-06 21:25                 ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 23:15               ` 2.6.20-rc6-mm3 Rob Landley
2007-02-06 23:28                 ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 23:55                   ` 2.6.20-rc6-mm3 Rob Landley
2007-02-06 22:11 ` [-mm patch] #ifdef ACPI_FUTURE_USAGE acpi_os_readable() Adrian Bunk
2007-02-06 22:12 ` [RFC: -mm patch] drivers/net/atl1/: possible cleanups Adrian Bunk
2007-02-07  0:19   ` Jay Cliburn [this message]
2007-02-07  0:22     ` Jeff Garzik
2007-02-07  0:24       ` J. K. Cliburn
2007-02-07  0:24     ` Adrian Bunk
2007-02-06 22:12 ` [-mm patch] drivers/scsi/aacraid/: cleanups Adrian Bunk
2007-02-06 22:12 ` [-mm patch] make gfs2_writepages() static Adrian Bunk
2007-02-07 10:50   ` Steven Whitehouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070206181910.4d27046a@osprey.hogchain.net \
    --to=jacliburn@bellsouth.net \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=csnook@redhat.com \
    --cc=jcliburn@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=xiong_huang@attansic.com \
    --subject='Re: [RFC: -mm patch] drivers/net/atl1/: possible cleanups' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).