LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alan <alan@lxorguk.ukuu.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Robert Hancock <hancockr@shaw.ca>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	drzeus-wbsd@drzeus.cx, wbsd-devel@list.drzeus.cx
Subject: Re: [PATCH] kernel: shut up the IRQ mismatch messages (Re: wbsd: IRQ handler type mismatch)
Date: Tue, 6 Feb 2007 19:46:26 +0000	[thread overview]
Message-ID: <20070206194626.5a8f47ab@localhost.localdomain> (raw)
In-Reply-To: <20070206112949.1fc99299.akpm@linux-foundation.org>

> > Signed-off-by: Alan Cox <alan@redhat.com>
> > 
> > --- linux.vanilla-2.6.20-rc6-mm3/kernel/irq/manage.c	2007-01-31 14:20:43.000000000 +0000
> > +++ linux-2.6.20-rc6-mm3/kernel/irq/manage.c	2007-02-06 11:01:00.796928504 +0000
> > @@ -372,12 +372,14 @@
> >  	return 0;
> >  
> >  mismatch:
> > +#ifdef CONFIG_DEBUG_SHIRQ
> >  	if (!(new->flags & IRQF_PROBE_SHARED)) {
> >  		printk(KERN_ERR "IRQ handler type mismatch for IRQ %d\n", irq);
> >  		if (old_name)
> >  			printk(KERN_ERR "current handler: %s\n", old_name);
> >  		dump_stack();
> >  	}
> > +#endif	
> >  	spin_unlock_irqrestore(&desc->lock, flags);
> >  	return -EBUSY;
> >  }
> 
> hm, well, it's dependent upon dwmw2's
> generate-a-spurious-irq-at-request_irq-time patch.  Do we want to merge
> that?

CONFIG_DEBUG_SHIRQ seemed to be the right configuration option
irrespective of whether we merge Dave's spurious irq tester (which I
think is actually a good test tool)

Alan

      reply	other threads:[~2007-02-06 19:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-06  3:16 wbsd: IRQ handler type mismatch Robert Hancock
2007-02-06  7:01 ` Pierre Ossman
2007-02-06 11:30 ` [PATCH] kernel: shut up the IRQ mismatch messages (Re: wbsd: IRQ handler type mismatch) Alan
2007-02-06 19:29   ` Andrew Morton
2007-02-06 19:46     ` Alan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070206194626.5a8f47ab@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=drzeus-wbsd@drzeus.cx \
    --cc=dwmw2@infradead.org \
    --cc=hancockr@shaw.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wbsd-devel@list.drzeus.cx \
    --subject='Re: [PATCH] kernel: shut up the IRQ mismatch messages (Re: wbsd: IRQ handler type mismatch)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).