[PATCH] input: Schedule removal of compaq touchscreen emulation (tsdev.c)

[PATCH] input: Schedule removal of compaq touchscreen emulation (tsdev.c)

[Richard Purdie]

Schedule removal of Compaq touchscreen emulation (drivers/input/tsdev.c)

Its old, was obsolete when it was written by the authors own admission
and much better userspace solutions like tslib now exist. The name is
also confusing.

Signed-off-by: Richard Purdie <rpurdie@rpsys.net> 

 Documentation/feature-removal-schedule.txt |   14 ++++++++++++++
 1 file changed, 14 insertions(+)

Index: linux/Documentation/feature-removal-schedule.txt
===================================================================
--- linux.orig/Documentation/feature-removal-schedule.txt	2007-02-06 09:40:43.000000000 +0000
+++ linux/Documentation/feature-removal-schedule.txt	2007-02-06 11:36:31.000000000 +0000
@@ -325,3 +325,17 @@ Why:	Unmaintained for years, superceded 
 Who:	Jeff Garzik <jeff@garzik.org>
 
 ---------------------------
+
+What:   Compaq touchscreen device emulation
+When:   Oct 2007
+Files:  drivers/input/tsdev.c
+Why:    The code says it was obsolete when it was written in 2001.
+        tslib is a userspace library which does anything tsdev can do and
+        much more besides in userspace where this code belongs. There is no
+        longer any need for tsdev and applications should have converted to
+        use tslib by now.
+        The name "tsdev" is also extremely confusing and lots of people have
+        it loaded when they don't need/use it.
+Who:    Richard Purdie <rpurdie@rpsys.net>
+
+---------------------------

Re: [PATCH] input: Schedule removal of compaq touchscreen emulation (tsdev.c)

[James Simmons]

My old driver. Yes please kill it.

Acked-By: James Simmons <jsimmons@infradead.org>

On Tue, 6 Feb 2007, Richard Purdie wrote:

> Schedule removal of Compaq touchscreen emulation (drivers/input/tsdev.c)
> 
> Its old, was obsolete when it was written by the authors own admission
> and much better userspace solutions like tslib now exist. The name is
> also confusing.
> 
> Signed-off-by: Richard Purdie <rpurdie@rpsys.net> 
> 
>  Documentation/feature-removal-schedule.txt |   14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> Index: linux/Documentation/feature-removal-schedule.txt
> ===================================================================
> --- linux.orig/Documentation/feature-removal-schedule.txt	2007-02-06 09:40:43.000000000 +0000
> +++ linux/Documentation/feature-removal-schedule.txt	2007-02-06 11:36:31.000000000 +0000
> @@ -325,3 +325,17 @@ Why:	Unmaintained for years, superceded 
>  Who:	Jeff Garzik <jeff@garzik.org>
>  
>  ---------------------------
> +
> +What:   Compaq touchscreen device emulation
> +When:   Oct 2007
> +Files:  drivers/input/tsdev.c
> +Why:    The code says it was obsolete when it was written in 2001.
> +        tslib is a userspace library which does anything tsdev can do and
> +        much more besides in userspace where this code belongs. There is no
> +        longer any need for tsdev and applications should have converted to
> +        use tslib by now.
> +        The name "tsdev" is also extremely confusing and lots of people have
> +        it loaded when they don't need/use it.
> +Who:    Richard Purdie <rpurdie@rpsys.net>
> +
> +---------------------------
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

Re: [PATCH] input: Schedule removal of compaq touchscreen emulation (tsdev.c)

[Andrew Morton]

On Tue, 06 Feb 2007 16:42:39 +0000 Richard Purdie <rpurdie@rpsys.net> wrote:

>  ---------------------------
> +
> +What:   Compaq touchscreen device emulation
> +When:   Oct 2007
> +Files:  drivers/input/tsdev.c
> +Why:    The code says it was obsolete when it was written in 2001.
> +        tslib is a userspace library which does anything tsdev can do and
> +        much more besides in userspace where this code belongs. There is no
> +        longer any need for tsdev and applications should have converted to
> +        use tslib by now.
> +        The name "tsdev" is also extremely confusing and lots of people have
> +        it loaded when they don't need/use it.
> +Who:    Richard Purdie <rpurdie@rpsys.net>

I think it best to add a printk to the driver's initialisation routine warning
any remaining users that it is going away.

Re: [PATCH] input: Schedule removal of compaq touchscreen emulation (tsdev.c)

[Richard Purdie]

On Tue, 2007-02-06 at 20:52 -0800, Andrew Morton wrote:
> On Tue, 06 Feb 2007 16:42:39 +0000 Richard Purdie <rpurdie@rpsys.net> wrote:
> 
> >  ---------------------------
> > +
> > +What:   Compaq touchscreen device emulation
> > +When:   Oct 2007
> > +Files:  drivers/input/tsdev.c
> > +Why:    The code says it was obsolete when it was written in 2001.
> > +        tslib is a userspace library which does anything tsdev can do and
> > +        much more besides in userspace where this code belongs. There is no
> > +        longer any need for tsdev and applications should have converted to
> > +        use tslib by now.
> > +        The name "tsdev" is also extremely confusing and lots of people have
> > +        it loaded when they don't need/use it.
> > +Who:    Richard Purdie <rpurdie@rpsys.net>
> 
> I think it best to add a printk to the driver's initialisation routine warning
> any remaining users that it is going away.

I suspect a message upon driver init will scare a lot of people due to
the "lots of people have it loaded when they don't need/use it" above.
How about printing something upon device open? A revised version is
below.

----

Schedule removal of Compaq touchscreen emulation (drivers/input/tsdev.c)

Its old, was obsolete when it was written by the authors own admission
and much better userspace solutions like tslib now exist. The name is
also confusing.

Signed-off-by: Richard Purdie <rpurdie@rpsys.net>
Acked-by: James Simmons <jsimmons@infradead.org>
---

 Documentation/feature-removal-schedule.txt |   14 ++++++++++++++
 drivers/input/tsdev.c                      |    4 ++++
 2 files changed, 18 insertions(+)

Index: linux/Documentation/feature-removal-schedule.txt
===================================================================
--- linux.orig/Documentation/feature-removal-schedule.txt	2007-02-06 20:32:59.000000000 +0000
+++ linux/Documentation/feature-removal-schedule.txt	2007-02-07 09:15:40.000000000 +0000
@@ -325,3 +325,17 @@ Why:	Unmaintained for years, superceded 
 Who:	Jeff Garzik <jeff@garzik.org>
 
 ---------------------------
+
+What:   Compaq touchscreen device emulation
+When:   Oct 2007
+Files:  drivers/input/tsdev.c
+Why:    The code says it was obsolete when it was written in 2001.
+        tslib is a userspace library which does anything tsdev can do and
+	much more besides in userspace where this code belongs. There is no
+	longer any need for tsdev and applications should have converted to
+	use tslib by now.
+        The name "tsdev" is also extremely confusing and lots of people have
+	it loaded when they don't need/use it.
+Who:    Richard Purdie <rpurdie@rpsys.net>
+
+---------------------------
Index: linux/drivers/input/tsdev.c
===================================================================
--- linux.orig/drivers/input/tsdev.c	2007-01-18 00:52:44.000000000 +0000
+++ linux/drivers/input/tsdev.c	2007-02-07 09:32:15.000000000 +0000
@@ -151,6 +151,10 @@ static int tsdev_open(struct inode *inod
 	int i = iminor(inode) - TSDEV_MINOR_BASE;
 	struct tsdev_list *list;
 
+	printk(KERN_WARNING "tsdev (compaq touchscreen emulation) is scheduled "
+		"for removal.\nSee Documentation/feature-removal-schedule.txt "
+		"for details.\n");
+
 	if (i >= TSDEV_MINORS || !tsdev_table[i & TSDEV_MINOR_MASK])
 		return -ENODEV;
 

Re: [PATCH] input: Schedule removal of compaq touchscreen emulation (tsdev.c)

[Jan-Benedict Glaw]

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

On Wed, 2007-02-07 10:23:46 +0000, Richard Purdie <rpurdie@rpsys.net> wrote:
> On Tue, 2007-02-06 at 20:52 -0800, Andrew Morton wrote:
> > On Tue, 06 Feb 2007 16:42:39 +0000 Richard Purdie <rpurdie@rpsys.net> wrote:
> --- linux.orig/drivers/input/tsdev.c	2007-01-18 00:52:44.000000000 +0000
> +++ linux/drivers/input/tsdev.c	2007-02-07 09:32:15.000000000 +0000
> @@ -151,6 +151,10 @@ static int tsdev_open(struct inode *inod
>  	int i = iminor(inode) - TSDEV_MINOR_BASE;
>  	struct tsdev_list *list;
>  
> +	printk(KERN_WARNING "tsdev (compaq touchscreen emulation) is scheduled "
> +		"for removal.\nSee Documentation/feature-removal-schedule.txt "
> +		"for details.\n");
> +
>  	if (i >= TSDEV_MINORS || !tsdev_table[i & TSDEV_MINOR_MASK])
>  		return -ENODEV;
>  

What about a hugh annoying mdelay()?

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of: 23:53 <@jbglaw> So, ich kletter' jetzt mal ins Bett.
the second  : 23:57 <@jever2> .oO( kletter ..., hat er noch Gitter vorm Bett, wie früher meine Kinder?)
              00:00 <@jbglaw> jever2: *patsch*
              00:01 <@jever2> *aua*, wofür, Gedanken sind frei!
              00:02 <@jbglaw> Nee, freie Gedanken, die sind seit 1984 doch aus!
              00:03 <@jever2> 1984? ich bin erst seit 1985 verheiratet!

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]