LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, James.Bottomley@SteelEye.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: [-mm patch] drivers/scsi/aacraid/: cleanups
Date: Tue, 6 Feb 2007 23:12:43 +0100	[thread overview]
Message-ID: <20070206221243.GI27397@stusta.de> (raw)
In-Reply-To: <20070129204528.eb8d695e.akpm@osdl.org>

On Mon, Jan 29, 2007 at 08:45:28PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.20-rc6-mm2:
>...
>  git-scsi-misc.patch
>...
>  git trees
>...


This patch contains the following cleanups:
- proper prototypes for global code in aacraid.h
- aac_rx_start_adapter() can now become static

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/scsi/aacraid/aacraid.h |    3 +++
 drivers/scsi/aacraid/linit.c   |    2 --
 drivers/scsi/aacraid/nark.c    |    3 ---
 drivers/scsi/aacraid/rkt.c     |    3 ---
 drivers/scsi/aacraid/rx.c      |    2 +-
 5 files changed, 4 insertions(+), 9 deletions(-)

--- linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/aacraid.h.old	2007-02-06 08:22:50.000000000 +0100
+++ linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/aacraid.h	2007-02-06 08:27:17.000000000 +0100
@@ -1840,8 +1840,11 @@
 int aac_get_adapter_info(struct aac_dev* dev);
 int aac_send_shutdown(struct aac_dev *dev);
 int aac_probe_container(struct aac_dev *dev, int cid);
+int _aac_rx_init(struct aac_dev *dev);
+int aac_rx_select_comm(struct aac_dev *dev, int comm);
 extern int numacb;
 extern int acbsize;
 extern char aac_driver_version[];
 extern int startup_timeout;
 extern int aif_timeout;
+extern int expose_physicals;
--- linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/rx.c.old	2007-02-06 08:21:40.000000000 +0100
+++ linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/rx.c	2007-02-06 08:21:50.000000000 +0100
@@ -294,7 +294,7 @@
  *	Start up processing on an i960 based AAC adapter
  */
 
-void aac_rx_start_adapter(struct aac_dev *dev)
+static void aac_rx_start_adapter(struct aac_dev *dev)
 {
 	struct aac_init *init;
 
--- linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/linit.c.old	2007-02-06 08:23:20.000000000 +0100
+++ linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/linit.c	2007-02-06 08:23:26.000000000 +0100
@@ -82,8 +82,6 @@
 static int aac_cfg_major = -1;
 char aac_driver_version[] = AAC_DRIVER_FULL_VERSION;
 
-extern int expose_physicals;
-
 /*
  * Because of the way Linux names scsi devices, the order in this table has
  * become important.  Check for on-board Raid first, add-in cards second.
--- linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/nark.c.old	2007-02-06 08:24:47.000000000 +0100
+++ linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/nark.c	2007-02-06 08:24:58.000000000 +0100
@@ -74,9 +74,6 @@
 
 int aac_nark_init(struct aac_dev * dev)
 {
-	extern int _aac_rx_init(struct aac_dev *dev);
-	extern int aac_rx_select_comm(struct aac_dev *dev, int comm);
-
 	/*
 	 *	Fill in the function dispatch table.
 	 */
--- linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/rkt.c.old	2007-02-06 08:25:07.000000000 +0100
+++ linux-2.6.20-rc6-mm3/drivers/scsi/aacraid/rkt.c	2007-02-06 08:25:20.000000000 +0100
@@ -45,7 +45,6 @@
 static int aac_rkt_select_comm(struct aac_dev *dev, int comm)
 {
 	int retval;
-	extern int aac_rx_select_comm(struct aac_dev *dev, int comm);
 	retval = aac_rx_select_comm(dev, comm);
 	if (comm == AAC_COMM_MESSAGE) {
 		/*
@@ -97,8 +96,6 @@
 
 int aac_rkt_init(struct aac_dev *dev)
 {
-	extern int _aac_rx_init(struct aac_dev *dev);
-
 	/*
 	 *	Fill in the function dispatch table.
 	 */


  parent reply	other threads:[~2007-02-06 22:12 UTC|newest]

Thread overview: 124+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-30  4:45 2.6.20-rc6-mm3 Andrew Morton
2007-01-30  4:50 ` 2.6.20-rc6-mm3 Jeff Garzik
2007-01-30  5:11   ` 2.6.20-rc6-mm3 Andrew Morton
2007-01-30  9:56     ` 2.6.20-rc6-mm3 Evgeniy Polyakov
2007-01-30  8:16 ` 2.6.20-rc6-mm3 Sunil Naidu
2007-01-30  8:32   ` 2.6.20-rc6-mm3 Andrew Morton
2007-01-30  9:06 ` 2.6.20-rc6-mm3 Olivier Galibert
2007-01-30  9:26   ` 2.6.20-rc6-mm3 Andrew Morton
2007-01-30 18:47     ` 2.6.20-rc6-mm3 Olivier Galibert
2007-01-31  7:57     ` 2.6.20-rc6-mm3 Len Brown
2007-02-01  4:25     ` 2.6.20-rc6-mm3 Len Brown
2007-01-30 22:18 ` 2.6.20-rc6-mm3 Maciej Rutecki
2007-01-30 22:27   ` 2.6.20-rc6-mm3 Andrew Morton
2007-01-31  0:55     ` 2.6.20-rc6-mm3 Karsten Wiese
2007-01-31 13:22       ` 2.6.20-rc6-mm3 Ingo Molnar
2007-01-31 14:25         ` 2.6.20-rc6-mm3 Karsten Wiese
2007-02-01  8:01           ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-01 10:44             ` 2.6.20-rc6-mm3 Karsten Wiese
2007-03-01 11:11               ` 2.6.20-rc6-mm3 Karsten Wiese
2007-02-03  0:37             ` 2.6.20-rc6-mm3 Pavel Machek
2007-02-01 13:03       ` [PATCH -mm] gtod persistent clock resume fix Thomas Gleixner
2007-01-31 11:54     ` 2.6.20-rc6-mm3 Maciej Rutecki
2007-02-01  4:10       ` 2.6.20-rc6-mm3 Len Brown
2007-02-01  4:17         ` 2.6.20-rc6-mm3 Andrew Morton
2007-01-31  1:16   ` 2.6.20-rc6-mm3 Tilman Schmidt
2007-01-31  1:25     ` 2.6.20-rc6-mm3 Andrew Morton
2007-01-31 11:38       ` 2.6.20-rc6-mm3 Tilman Schmidt
2007-01-31 12:29         ` 2.6.20-rc6-mm3 Alexey Starikovskiy
2007-01-31 16:02           ` 2.6.20-rc6-mm3 Maciej Rutecki
2007-01-31 18:28           ` 2.6.20-rc6-mm3 Tilman Schmidt
2007-01-31 21:52 ` 2.6.20-rc6-mm3 Mattia Dongili
2007-01-31 23:21   ` 2.6.20-rc6-mm3 Mattia Dongili
2007-02-01 19:04     ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-01 19:36     ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-01 20:01       ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-01 21:11         ` 2.6.20-rc6-mm3 Mattia Dongili
2007-02-01 22:33           ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-02 19:18             ` dynticks + iptables almost stops the boot process [was: Re: 2.6.20-rc6-mm3] Mattia Dongili
2007-02-02 20:27               ` Thomas Gleixner
2007-02-02 20:43                 ` Mattia Dongili
2007-02-06 16:48                   ` Ingo Molnar
2007-02-06 19:28                     ` Mattia Dongili
2007-02-06 23:12                       ` Tilman Schmidt
2007-02-06 23:17                         ` Thomas Gleixner
2007-02-07  1:01                           ` Andrew Morton
2007-02-07 19:33                             ` Ingo Molnar
2007-02-01 21:37         ` 2.6.20-rc6-mm3 Mattia Dongili
2007-02-01 20:24       ` 2.6.20-rc6-mm3 Mattia Dongili
2007-02-01  0:14 ` 2.6.20-rc6-mm3 Christoph Lameter
2007-02-01  0:24   ` 2.6.20-rc6-mm3 Andrew Morton
2007-02-01  0:27     ` 2.6.20-rc6-mm3 Christoph Lameter
2007-02-01  0:36       ` 2.6.20-rc6-mm3 Andrew Morton
2007-02-01  0:38         ` 2.6.20-rc6-mm3 Christoph Lameter
2007-02-01  6:20         ` 2.6.20-rc6-mm3 David Chinner
2007-02-01  7:12           ` 2.6.20-rc6-mm3 Andrew Morton
2007-02-01 19:01             ` 2.6.20-rc6-mm3 Christoph Lameter
2007-02-01 19:18               ` 2.6.20-rc6-mm3 Jens Axboe
2007-02-01 20:18                 ` 2.6.20-rc6-mm3 Christoph Lameter
2007-02-01 20:26                   ` 2.6.20-rc6-mm3 Jens Axboe
2007-02-01 23:02                     ` 2.6.20-rc6-mm3 Christoph Lameter
2007-02-05 12:02                       ` 2.6.20-rc6-mm3 Jens Axboe
2007-02-05 12:17                         ` 2.6.20-rc6-mm3 Jens Axboe
2007-02-05 12:56                           ` 2.6.20-rc6-mm3 Jens Axboe
2007-02-05 18:20                             ` 2.6.20-rc6-mm3 Christoph Lameter
2007-02-05 18:34                               ` 2.6.20-rc6-mm3 Jens Axboe
2007-02-02  4:08                 ` 2.6.20-rc6-mm3 David Chinner
2007-02-02  7:31                   ` 2.6.20-rc6-mm3 Jens Axboe
2007-02-01 18:24 ` 2.6.20-rc6-mm3 Cedric Le Goater
2007-02-01 19:37   ` 2.6.20-rc6-mm3 Starikovskiy, Alexey Y
2007-02-01 20:29     ` 2.6.20-rc6-mm3 Cedric Le Goater
2007-02-01 20:38       ` 2.6.20-rc6-mm3 Cedric Le Goater
2007-02-02 14:22         ` 2.6.20-rc6-mm3 Starikovskiy, Alexey Y
2007-02-02 14:47           ` 2.6.20-rc6-mm3 Cedric Le Goater
2007-02-02 14:50             ` 2.6.20-rc6-mm3 Starikovskiy, Alexey Y
2007-02-02 16:04               ` 2.6.20-rc6-mm3 Cedric Le Goater
2007-02-03  7:30                 ` 2.6.20-rc6-mm3 Cedric Le Goater
2007-02-03  7:57                   ` 2.6.20-rc6-mm3 Starikovskiy, Alexey Y
2007-02-02 17:39 ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 16:03 ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 18:36   ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-06 18:45     ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 19:07       ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-06 19:55         ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 20:20           ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-06 20:40             ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 20:52               ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-06 20:56                 ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 21:09                   ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-06 21:20                     ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-06 21:23                     ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 21:41                       ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-06 21:54                         ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 22:08                           ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-06 22:42                             ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 22:56                               ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-06 23:04                                 ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 23:14                                   ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-06 23:22                                     ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 23:28                                       ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-06 23:35                                         ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 23:44                                           ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-06 23:51                                           ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-07  2:46                                             ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 23:36                                       ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-07  1:12                                         ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-07 14:53                                           ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-06 23:37                                       ` 2.6.20-rc6-mm3 Ingo Molnar
2007-02-06 22:13                           ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-06 21:43                       ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-06 21:59                         ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 21:17               ` 2.6.20-rc6-mm3 Thomas Gleixner
2007-02-06 21:25                 ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 23:15               ` 2.6.20-rc6-mm3 Rob Landley
2007-02-06 23:28                 ` 2.6.20-rc6-mm3 Daniel Walker
2007-02-06 23:55                   ` 2.6.20-rc6-mm3 Rob Landley
2007-02-06 22:11 ` [-mm patch] #ifdef ACPI_FUTURE_USAGE acpi_os_readable() Adrian Bunk
2007-02-06 22:12 ` [RFC: -mm patch] drivers/net/atl1/: possible cleanups Adrian Bunk
2007-02-07  0:19   ` Jay Cliburn
2007-02-07  0:22     ` Jeff Garzik
2007-02-07  0:24       ` J. K. Cliburn
2007-02-07  0:24     ` Adrian Bunk
2007-02-06 22:12 ` Adrian Bunk [this message]
2007-02-06 22:12 ` [-mm patch] make gfs2_writepages() static Adrian Bunk
2007-02-07 10:50   ` Steven Whitehouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070206221243.GI27397@stusta.de \
    --to=bunk@stusta.de \
    --cc=James.Bottomley@SteelEye.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --subject='Re: [-mm patch] drivers/scsi/aacraid/: cleanups' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).