LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tomasz Kvarsin <kvarsin@gmail.com>,
	viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: warrning fix: unsigned->signed
Date: Wed, 7 Feb 2007 12:56:26 +0100	[thread overview]
Message-ID: <20070207115626.GF4487@kernel.dk> (raw)
In-Reply-To: <20070206140936.24bbaded.akpm@linux-foundation.org>

On Tue, Feb 06 2007, Andrew Morton wrote:
> On Wed, 7 Feb 2007 00:39:45 +0300
> "Tomasz Kvarsin" <kvarsin@gmail.com> wrote:
> 
> > While compiling my code, I always get bunch of warrning from headers,
> > here is fix for them:
> > __getblk is alawys called with unsigned argument,
> > but it takes signed, the same story with __bread,__breadahead and so on.
> 
> The patch seems OK, but I'm curious to know why you're seeing this warning
> and nobody else is.  Are you using a compiler other than gcc?  If gcc,
> which version?  Did you add any new compiler options?

While I'm not a big fan of fixing signed vs unsigned -W generated
warnings (they tend to cause more harm than good), this patch looks ok
to me as well.

-- 
Jens Axboe


      parent reply	other threads:[~2007-02-07 11:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-06 21:39 Tomasz Kvarsin
2007-02-06 22:09 ` Andrew Morton
2007-02-06 22:55   ` Oleg Verych
2007-02-07  5:31   ` Tomasz Kvarsin
2007-02-07 11:56   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070207115626.GF4487@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=kvarsin@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: [PATCH]: warrning fix: unsigned->signed' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).