LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, jeff@garzik.org
Subject: Re: [PATCH] pata_acpi: take two
Date: Wed, 7 Feb 2007 21:38:02 +0100	[thread overview]
Message-ID: <200702072138.03167.m.kozlowski@tuxland.pl> (raw)
In-Reply-To: <20070207172220.04c96dc5@localhost.localdomain>

Hello,

	Just asking ... in:

> +static void *ata_pata_find_handle(struct device *dev, int port)

...

> +       chan_handle = acpi_get_child(handle, port);
> +       if (chan_handle == NULL)
> +               return NULL;
> +       return chan_handle;
> +}

why not simply:

	return acpi_get_child(hadnle, port);

?

Regards,

	Mariusz Kozlowski

  reply	other threads:[~2007-02-07 20:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-07 17:22 Alan
2007-02-07 20:38 ` Mariusz Kozlowski [this message]
2007-02-08  0:30 ` Andrew Morton
2007-02-09 20:13   ` Alan
     [not found] <fa.E0XxdpTYuPtTLgPLQYHs2V10jM4@ifi.uio.no>
2007-02-08  5:12 ` Robert Hancock
2007-02-09 20:18   ` Alan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702072138.03167.m.kozlowski@tuxland.pl \
    --to=m.kozlowski@tuxland.pl \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] pata_acpi: take two' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).