LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org
Subject: checker-shell still hosed...
Date: Thu, 08 Feb 2007 03:05:31 -0800 (PST)	[thread overview]
Message-ID: <20070208.030531.112264703.davem@davemloft.net> (raw)


Linus, things still fail for me even with the $(strip ...) construct
you added works properly.

For some reason things like $(call cc-option-yn...) still fail.

My make version 3.81beta4 has the space problem, and with your
change it just returns a space. :-)  Without your change it
gives the problematic " y" string.

A running theory of mine is that it's a "$(call)" within a
$(call) which generates the space.  So I wrote a little
make.test:

define test1
  $(shell echo "str1")
endef

define test2
  $(call test1)
endef

FOO := A$(call test2)B

all:
	echo A$(FOO)B

If I run "make -f make.test" I get:

davem@sunset:~/src/GIT/net-2.6$ make -f make.test
echo AA    str1BB
AA str1BB
davem@sunset:~/src/GIT/net-2.6$

Hmmm...  but I just checked on a proper "GNU Make 3.81" and that
prints the space in the example above too.

Weird...


             reply	other threads:[~2007-02-08 11:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08 11:05 David Miller [this message]
2007-02-08 12:10 ` David Miller
2007-02-08 12:12   ` David Miller
2007-02-08 12:41     ` Geert Uytterhoeven
2007-02-08 12:52       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070208.030531.112264703.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: checker-shell still hosed...' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).