LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Andi Kleen <ak@suse.de>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	LKML <linux-kernel@vger.kernel.org>,
	clameter@sgi.com, GOTO <y-goto@jp.fujitsu.com>
Subject: Re: [BUG][PATCH] fix mempolcy's check on a system with memory-less-node take2
Date: Thu, 8 Feb 2007 00:08:57 -0800	[thread overview]
Message-ID: <20070208000857.7296b94b.akpm@linux-foundation.org> (raw)
In-Reply-To: <200702080903.46242.ak@suse.de>

On Thu, 8 Feb 2007 09:03:46 +0100 Andi Kleen <ak@suse.de> wrote:

> On Thursday 08 February 2007 09:00, Andrew Morton wrote:
> > On Thu, 8 Feb 2007 08:49:41 +0100 Andi Kleen <ak@suse.de> wrote:
> > 
> > > 
> > > > This panic(hang) was found by a numa test-set on a system with 3 nodes, where
> > > > node(2) was memory-less-node.
> > > 
> > > I still think it's the wrong fix -- just get rid of the memory less node.
> > 
> > "Let's break it even more"?
> 
> I still don't get what you believe what would be broken then.

A node with no memory is physical reality.  The kernel should do its best
handle and report it accurately.  Pretending that the CPUs on that node are
local to a different node's memory (as I understand your proposal) goes
against that.

> > > I expect you'll likely run into more problems with that setup anyways.
> > 
> > What happens if he doesn't run into more problems?
> 
> Then he's lucky. I ran into problems at least when I still had the empty
> nodes some time ago on x86-64.  Christoph said SN2 is doing the same.
> 
> iirc slab blew up at least, but that  might be fixed by now. But it's a little risky 
> because there is more code now that is node aware.
> 

Well...  I'd suggest that we try to struggle on, get it working.  Is there
a downside to doing that?  

  reply	other threads:[~2007-02-08  8:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08  2:06 KAMEZAWA Hiroyuki
2007-02-08  7:49 ` Andi Kleen
2007-02-08  8:00   ` Andrew Morton
2007-02-08  8:03     ` Andi Kleen
2007-02-08  8:08       ` Andrew Morton [this message]
2007-02-08  8:19         ` Andi Kleen
2007-02-08  8:24           ` Andrew Morton
2007-02-08  8:16   ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070208000857.7296b94b.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=ak@suse.de \
    --cc=clameter@sgi.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=y-goto@jp.fujitsu.com \
    --subject='Re: [BUG][PATCH] fix mempolcy'\''s check on a system with memory-less-node take2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).