LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Oleg Verych <olecom@flower.upol.cz>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] refix localversion handling
Date: Thu, 8 Feb 2007 01:31:27 +0100	[thread overview]
Message-ID: <20070208003127.GD22699@flower.upol.cz> (raw)
In-Reply-To: <Pine.LNX.4.64.0702080109550.14457@scrub.home>

On Thu, Feb 08, 2007 at 01:13:39AM +0100, Roman Zippel wrote:
> Hi,
> 
> This reverts part of the localversion patch, which now already got into 
> git. It removes the unnecessary find call, with the simpler $(notdir ...) 
> fix.

I'm certainly have more stuff to deal with, but that was my attept to
prevent bloatware in makefiles (unlucky "meat" from "flies" split ;)

>  
> -pattern = ".*/localversion[^~]*"
> -string  = $(shell cat /dev/null \
> -	   `find $(objtree) $(srctree) -maxdepth 1 -regex $(pattern) | sort`)
> -
> -localver = $(subst $(space),, $(string) \
> -			      $(patsubst "%",%,$(CONFIG_LOCALVERSION)))
> +___localver = $(objtree)/localversion* $(srctree)/localversion*
> +__localver  = $(sort $(wildcard $(___localver)))
> +# skip files containing '~' (like backup files)
> +_localver = $(foreach f,$(__localver),$(if $(findstring ~,$(notdir $(f))),,$(f)))
> +
> +localver = $(subst $(space),, \
> +	   $(shell cat /dev/null $(_localver)) \
> +	   $(patsubst "%",%,$(CONFIG_LOCALVERSION)))
____

      reply	other threads:[~2007-02-08  0:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08  0:13 Roman Zippel
2007-02-08  0:31 ` Oleg Verych [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070208003127.GD22699@flower.upol.cz \
    --to=olecom@flower.upol.cz \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zippel@linux-m68k.org \
    --subject='Re: [PATCH] refix localversion handling' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).