LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Oleg Verych <olecom@flower.upol.cz>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	torvalds@osdl.org, sam@ravnborg.org,
	linux-kernel@vger.kernel.org
Subject: discussion of Kbuild fixes (kbuild: Kbuild.include avoid using spaces in call arguments)
Date: Thu, 8 Feb 2007 02:20:49 +0100	[thread overview]
Message-ID: <20070208012049.GE22699@flower.upol.cz> (raw)
In-Reply-To: <Pine.LNX.4.64.0702080051520.14457@scrub.home>

On Thu, Feb 08, 2007 at 01:00:44AM +0100, Roman Zippel wrote:
> Hi,
> 
> On Wed, 7 Feb 2007, Randy Dunlap wrote:
> 
> > > > > Linus, please revert. Thanks.
> > > >  
> > > > Roman, while it went so fast to Linus, i didn't expect that, let me
> > > > try to fix all this with this little patch.
> > > 
> > > Sorry, it needs more changes, the patch simply wasn't ready.
> > 
> > Can you be more explicit?  and then it should get some time
> > in -mm, hopefully.
> 
> I did already. It needs to be splitted,

i did that patch for ultrasonic testers of Linus's tree. Shame on me,
because, i was sure, that... whatever. This is where i thought, that i
almost understand it all, but another huge level of complexity was
revealed (even it's just a whitespace ;).

I've started to split changes,

> lose the symlink stuff and be more careful with whitespace. It probably
> could use a better name than checker-shell, e.g. autoconf calls this
> TRY_RUN, so something like this.

but i can't understand you, Roman, against:

-- `find | sort' in localversion (i insist on split between paths and
    files)

-- symlinks to /dev/null in option checking -- isn't it better to not
   have any (though cached) access to files on filesystem, instead of to
   /dev/null? cont.:
 
Anyway, i think, it's better than before, that now all is one place, and
can be named as you wish. Any further changes, like common `tmp'
directory are easy to fix. Readable form, easy to test/debug:

add `-x' to `set' or `echo >gcc-checks.txt', and you will get output, you wish.

IMHO it's good, while arch specific gcc checking already done (:

I wish to have more people to work on this (even with just comments),
because "Kbuild.include" was only first step to reduce bloated top
Makefile. Since then, it seems, Sam have more important things to do.

If further work is useful, i will be glad if you think so.

Thanks.
____

  reply	other threads:[~2007-02-08  1:12 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-07 16:52 -mcpu strikes back Alexey Dobriyan
2007-02-07 17:47 ` Roman Zippel
2007-02-07 22:04   ` [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments Oleg Verych
2007-02-07 23:34     ` Roman Zippel
2007-02-07 23:38       ` Randy Dunlap
2007-02-08  0:00         ` Roman Zippel
2007-02-08  1:20           ` Oleg Verych [this message]
2007-02-08  2:05             ` discussion of Kbuild fixes (kbuild: Kbuild.include avoid using spaces in call arguments) Roman Zippel
2007-02-08  2:59               ` Oleg Verych
2007-02-07 23:52       ` [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments Linus Torvalds
2007-02-08  0:03         ` Roman Zippel
2007-02-08  4:30         ` Andrew Morton
2007-02-08  5:24           ` dd Oleg Verych
2007-02-08  5:19             ` dd Andrew Morton
2007-02-08  5:58               ` + search-a-little-harder-for-mkimage.patch Oleg Verych
2007-02-08  5:58                 ` Mike Frysinger
2007-02-08  6:43                   ` Oleg Verych
2007-02-08  6:42                     ` Mike Frysinger
2007-02-08 11:29                     ` Jan Engelhardt
2007-02-08 16:38                 ` Roman Zippel
2007-02-08 18:39                   ` Oleg Verych
2007-02-08  5:56             ` dd Mike Frysinger
2007-02-08  7:42               ` search-a-little-harder-for-mkimage.patch Oleg Verych
2007-02-08  7:40                 ` search-a-little-harder-for-mkimage.patch Mike Frysinger
2007-02-08  8:04                   ` search-a-little-harder-for-mkimage.patch Oleg Verych
2007-02-08  5:39           ` + make-mkcompile_h-use-lang=c-and-lc_all=c-for-cc-v.patch Oleg Verych
2007-02-08 16:34           ` [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments Roman Zippel
     [not found]           ` <20070208064029.GO22699@flower.upol.cz>
     [not found]             ` <20070207224227.a23ca154.akpm@linux-foundation.org>
2007-02-23  0:02               ` .mailmap in top directory Oleg Verych
2007-02-08 15:48         ` [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070208012049.GE22699@flower.upol.cz \
    --to=olecom@flower.upol.cz \
    --cc=adobriyan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=sam@ravnborg.org \
    --cc=torvalds@osdl.org \
    --cc=zippel@linux-m68k.org \
    --subject='Re: discussion of Kbuild fixes (kbuild: Kbuild.include avoid using spaces in call arguments)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).