LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Eric Dumazet <dada1@cosmosbay.com>,
	Lukasz Trabinski <lukasz@wsisiz.edu.pl>,
	linux-kernel@vger.kernel.org,
	Bartlomiej Solarz-Niesluchowski <solarz@wsisiz.edu.pl>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: 2.6.20 BUG: soft lockup detected on CPU#0!
Date: Thu, 8 Feb 2007 02:12:12 -0800	[thread overview]
Message-ID: <20070208021212.a26ead6e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070208095612.GA9977@elte.hu>

On Thu, 8 Feb 2007 10:56:12 +0100 Ingo Molnar <mingo@elte.hu> wrote:

> 
> * Eric Dumazet <dada1@cosmosbay.com> wrote:
> 
> > This reminds me the current problem in close_files()
> >  code, where we trigger soft lockup quite regularly.
> > 
> > Is there any chance/interest we can solve the issue Andrew had with 
> > this patch ?
> > 
> > http://lkml.org/lkml/2006/5/2/273
> 
> yes - the -rt patch included the patch below for more than 2 years. 
> (note that this one is even more finegrained)
> 
> 	Ingo
> 
> Index: linux/kernel/exit.c
> ===================================================================
> --- linux.orig/kernel/exit.c
> +++ linux/kernel/exit.c
> @@ -431,8 +433,10 @@ static void close_files(struct files_str
>  		while (set) {
>  			if (set & 1) {
>  				struct file * file = xchg(&fdt->fd[i], NULL);
> -				if (file)
> +				if (file) {
>  					filp_close(file, files);
> +					cond_resched();
> +				}
>  			}
>  			i++;
>  			set >>= 1;

That doesn't hang like the other patch did on 2.6.17-rc3.

Very mysterious.

  reply	other threads:[~2007-02-08 10:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-07 23:02 Lukasz Trabinski
2007-02-08  4:47 ` Andrew Morton
2007-02-08  8:06   ` Ingo Molnar
2007-02-08  8:15     ` Andrew Morton
2007-02-08  9:16     ` Eric Dumazet
2007-02-08  9:56       ` Ingo Molnar
2007-02-08 10:12         ` Andrew Morton [this message]
2007-02-08 15:51   ` Lukasz Trabinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070208021212.a26ead6e.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dada1@cosmosbay.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukasz@wsisiz.edu.pl \
    --cc=mingo@elte.hu \
    --cc=solarz@wsisiz.edu.pl \
    --cc=tglx@linutronix.de \
    --subject='Re: 2.6.20 BUG: soft lockup detected on CPU#0'\!'' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).