LKML Archive on
help / color / mirror / Atom feed
From: Horms <>
To: "Luck, Tony" <>
Cc:,,, "Zou, Nanhai" <>,
	Khalid Aziz <>,
	Adrian Bunk <>,
	Andrew Morton <>,
	Magnus Damm <>
Subject: Re: [PATCH] [IA64] Include kexec.h in arch/ia64/kernel/process.c
Date: Thu, 8 Feb 2007 11:19:03 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Feb 07, 2007 at 09:07:40AM -0800, Luck, Tony wrote:
> > kexec.h is needed by arch/ia64/kernel/process.c so for the
> > declaration of kexec_disable_iosapic() which is used in
> > machine_shutdown().
> > +#include <asm/kexec.h>
> I merged this into your earlier change (moving machine_shutdown() into
> process.c).  Linus pulled it last night.


> I also added a "#ifdef CONFIG_KEXEC" around the call to
> kexec_disable_iosapic() (because I first noticed that this was
> undefined when building non-KEXEC kernels).  But perhaps it might have
> been better to #define an empty stub for this function inside kexec.h
> for the #ifndef CONFIG_KEXEC case?

Good catch :)

I think that #define in the process.c vs an empty stub inside
asm/kexec.h is really a style issue. I'm quite ok with things
the way they are. But If you are more comfortable with the stub
approach, I have no objections.


  reply	other threads:[~2007-02-08  3:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-07  6:49 Horms
2007-02-07 17:07 ` Luck, Tony
2007-02-08  2:19   ` Horms [this message]
2007-02-08  3:27     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] [IA64] Include kexec.h in arch/ia64/kernel/process.c' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).