LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Horms <horms@verge.net.au>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
	fastboot@lists.osdl.org, "Zou, Nanhai" <nanhai.zou@intel.com>,
	Khalid Aziz <khalid_aziz@hp.com>,
	Adrian Bunk <trivial@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH] [IA64] Include kexec.h in arch/ia64/kernel/process.c
Date: Thu, 8 Feb 2007 11:19:03 +0900	[thread overview]
Message-ID: <20070208021900.GB17585@verge.net.au> (raw)
In-Reply-To: <617E1C2C70743745A92448908E030B2A0117C67C@scsmsx411.amr.corp.intel.com>

On Wed, Feb 07, 2007 at 09:07:40AM -0800, Luck, Tony wrote:
> > kexec.h is needed by arch/ia64/kernel/process.c so for the
> > declaration of kexec_disable_iosapic() which is used in
> > machine_shutdown().
> 
> > +#include <asm/kexec.h>
> 
> I merged this into your earlier change (moving machine_shutdown() into
> process.c).  Linus pulled it last night.

Thanks

> I also added a "#ifdef CONFIG_KEXEC" around the call to
> kexec_disable_iosapic() (because I first noticed that this was
> undefined when building non-KEXEC kernels).  But perhaps it might have
> been better to #define an empty stub for this function inside kexec.h
> for the #ifndef CONFIG_KEXEC case?

Good catch :)

I think that #define in the process.c vs an empty stub inside
asm/kexec.h is really a style issue. I'm quite ok with things
the way they are. But If you are more comfortable with the stub
approach, I have no objections.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


  reply	other threads:[~2007-02-08  3:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-07  6:49 Horms
2007-02-07 17:07 ` Luck, Tony
2007-02-08  2:19   ` Horms [this message]
2007-02-08  3:27     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070208021900.GB17585@verge.net.au \
    --to=horms@verge.net.au \
    --cc=akpm@linux-foundation.org \
    --cc=fastboot@lists.osdl.org \
    --cc=khalid_aziz@hp.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=nanhai.zou@intel.com \
    --cc=tony.luck@intel.com \
    --cc=trivial@kernel.org \
    --subject='Re: [PATCH] [IA64] Include kexec.h in arch/ia64/kernel/process.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).