LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Oleg Verych <olecom@flower.upol.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mike Frysinger <vapier.adi@gmail.com>,
	Roman Zippel <zippel@linux-m68k.org>,
	sam@ravnborg.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Kai Germaschewski <kai@germaschewski.name>
Subject: dd
Date: Thu, 8 Feb 2007 06:24:40 +0100	[thread overview]
Message-ID: <20070208052439.GL22699@flower.upol.cz> (raw)
In-Reply-To: <20070207203047.51a95ad0.akpm@linux-foundation.org>

Hallo.

search-a-little-harder-for-mkimage.patch

------------------------------------------------------
Subject: search a little harder for mkimage
From: "Mike Frysinger" <vapier.adi@gmail.com>

> Check to see if `${CROSS_COMPILE}mkimage` exists and if not, fall back to
> the standard `mkimage`

Why this can't be done by

  PATH=$CROSS_COMPILE:$PATH

in your environment?

> The Blackfin toolchain includes mkimage, but we dont want to namespace
> collide with any of the user's system setup, so we prefix it with our
> toolchain name.

If that matter, `type -path' is bashizm (BloAted SHell), and "blackbox"
with "dash" (very good `sh' equivalents) will fail. I would recomend to
use "which" command (btw, Debian has `sh' version of it), if you
concerned about size and performance.

Nack + proposition to move from `bash' to `sh'.

-MKIMAGE=$(type -path mkimage)
+MKIMAGE=$(type -path ${CROSS_COMPILE}mkimage)
 
 if [ -z "${MKIMAGE}" ]; then
-	# Doesn't exist
-	echo '"mkimage" command not found - U-Boot images will not be built' >&2
-	exit 0;
+	MKIMAGE=$(type -path mkimage)
+	if [ -z "${MKIMAGE}" ]; then
+		# Doesn't exist
+		echo '"mkimage" command not found - U-Boot images will not be built' >&2
+		exit 0;
+	fi
 fi

____

  reply	other threads:[~2007-02-08  5:15 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-07 16:52 -mcpu strikes back Alexey Dobriyan
2007-02-07 17:47 ` Roman Zippel
2007-02-07 22:04   ` [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments Oleg Verych
2007-02-07 23:34     ` Roman Zippel
2007-02-07 23:38       ` Randy Dunlap
2007-02-08  0:00         ` Roman Zippel
2007-02-08  1:20           ` discussion of Kbuild fixes (kbuild: Kbuild.include avoid using spaces in call arguments) Oleg Verych
2007-02-08  2:05             ` Roman Zippel
2007-02-08  2:59               ` Oleg Verych
2007-02-07 23:52       ` [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments Linus Torvalds
2007-02-08  0:03         ` Roman Zippel
2007-02-08  4:30         ` Andrew Morton
2007-02-08  5:24           ` Oleg Verych [this message]
2007-02-08  5:19             ` dd Andrew Morton
2007-02-08  5:58               ` + search-a-little-harder-for-mkimage.patch Oleg Verych
2007-02-08  5:58                 ` Mike Frysinger
2007-02-08  6:43                   ` Oleg Verych
2007-02-08  6:42                     ` Mike Frysinger
2007-02-08 11:29                     ` Jan Engelhardt
2007-02-08 16:38                 ` Roman Zippel
2007-02-08 18:39                   ` Oleg Verych
2007-02-08  5:56             ` dd Mike Frysinger
2007-02-08  7:42               ` search-a-little-harder-for-mkimage.patch Oleg Verych
2007-02-08  7:40                 ` search-a-little-harder-for-mkimage.patch Mike Frysinger
2007-02-08  8:04                   ` search-a-little-harder-for-mkimage.patch Oleg Verych
2007-02-08  5:39           ` + make-mkcompile_h-use-lang=c-and-lc_all=c-for-cc-v.patch Oleg Verych
2007-02-08 16:34           ` [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments Roman Zippel
     [not found]           ` <20070208064029.GO22699@flower.upol.cz>
     [not found]             ` <20070207224227.a23ca154.akpm@linux-foundation.org>
2007-02-23  0:02               ` .mailmap in top directory Oleg Verych
2007-02-08 15:48         ` [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070208052439.GL22699@flower.upol.cz \
    --to=olecom@flower.upol.cz \
    --cc=akpm@linux-foundation.org \
    --cc=kai@germaschewski.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=vapier.adi@gmail.com \
    --cc=zippel@linux-m68k.org \
    --subject='Re: dd' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).